FS#23774 - Arch package query parameter not properly encoded

Attached to Project: AUR web interface
Opened by Marcel Korpel (Marcel-) - Friday, 15 April 2011, 09:07 GMT
Last edited by Lukas Fleischer (lfleischer) - Saturday, 20 August 2011, 18:17 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Medium
Priority Normal
Reported Version 1.8.1
Due in Version 1.9.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Several packages in the AUR depend on stock Arch packages. When viewing package details I can automatically search those packages using a URL like http://www.archlinux.org/packages/?q=%s.

However, the query parameter is not properly encoded according to RFC 3986. For example, on https://aur.archlinux.org/packages.php?ID=2697 there's a dependency on 'libstdc++5' with a link to http://www.archlinux.org/packages/?q=libstdc++5; of course, this is incorrect, the query parameter should be 'libstdc%2B%2B5'.

Proposal: use rawurlencode to encode the query parameter.
   repair-query-param.patch (0.6 KiB)
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Saturday, 20 August 2011, 18:17 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.9.0.
Comment by Marcel Korpel (Marcel-) - Monday, 18 April 2011, 13:25 GMT
Oops, one should use `urlencode` instead of `rawurlencode` to encode query parameters. Corrected patch.
   repair-query-param.patch (0.5 KiB)
Comment by Lukas Fleischer (lfleischer) - Tuesday, 19 April 2011, 22:24 GMT
  • Field changed: Due in Version (Undecided → 1.9.0)
Fixed [1].

[1] http://projects.archlinux.org/aur.git/commit/?id=0e5f2e1f1efe520da6f9c9d7db4bc3dec7e589e6

Loading...