FS#23543 - [patch] document PACKAGER environment variable in makepkg

Attached to Project: Pacman
Opened by Phillip Smith (fukawi2) - Friday, 01 April 2011, 01:08 GMT
Last edited by Allan McRae (Allan) - Thursday, 22 December 2011, 06:21 GMT
Task Type Feature Request
Category Documentation
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 3.5.1
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Attached is a patch to document the PACKAGER env var in makepkg man page. The variable already works, it just isn't documented.
   0001-add-documentation-of-PAC... (0.9 KiB)
This task depends upon

Closed by  Allan McRae (Allan)
Thursday, 22 December 2011, 06:21 GMT
Reason for closing:  Implemented
Additional comments about closing:  http://projects.archlinux.org/pacman.git /commit/?id=5ba8b83b
Comment by Dan McGee (toofishes) - Friday, 01 April 2011, 01:44 GMT
Didn't know this actually worked. Are you sure it overrides if uncommented in makepkg.conf?

We should probably also make the text read more similar to that in man makepkg.conf; I don't think we use "Your" or that type of directed language anywhere else in option/envvar descriptions.
Comment by Phillip Smith (fukawi2) - Friday, 01 April 2011, 01:50 GMT
Bugger, I just re-tested and no it doesn't override /etc/makepkg.conf

It only works if not set in a file on disk. (ie, /etc/makepkg.conf or ~/.makepkg.conf)

I'll dig into that and supply another patch. I can attach it here, or close this if you like and I'll make a new FS task.
Comment by Dan McGee (toofishes) - Friday, 01 April 2011, 02:00 GMT
Definitely don't close/open tasks, that is silly and a waste of everyone's time. :)

It should be a one-line addition to makepkg.conf in the vain of other variables we do allow this with; e.g. PKGDEST. Poke around and take a look.
Comment by Dan McGee (toofishes) - Monday, 22 August 2011, 16:43 GMT
Ping?
Comment by Phillip Smith (fukawi2) - Monday, 22 August 2011, 23:28 GMT
Ah yeah... Not sure where I got with this... Horribly distracted it would seem :S

I'll have a another look.
Comment by Phillip Smith (fukawi2) - Tuesday, 01 November 2011, 01:02 GMT
Fresh patch attached, including mods to makepkg to support the expected behavior described in the original FS.
   0001-makepkg-add-support-for-... (1.9 KiB)
Comment by Allan McRae (Allan) - Sunday, 20 November 2011, 05:23 GMT
Patch pulled to my working branch with slight documentation fix.

Loading...