FS#23457 - [libgme] Patch to allow libgme to be found by pkg-config.

Attached to Project: Arch Linux
Opened by James (JRMoore) - Saturday, 26 March 2011, 18:55 GMT
Last edited by Jan de Groot (JGC) - Monday, 09 May 2011, 10:53 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The attached patch registers libgme with pkg-config, other programs rely in it to find this library (e.g. mpd).

The other attached patch changes the visibility of some internal symbols not to be exported, if added too it should be applied after the one that enables pkg-config support.
This task depends upon

Closed by  Jan de Groot (JGC)
Monday, 09 May 2011, 10:53 GMT
Reason for closing:  Fixed
Additional comments about closing:  Updated to r33 SVN snapshot. Last ticket upstream tells them to make a release, so far current SVN seems to be "as perfect as it can get".
Comment by Ionut Biru (wonder) - Saturday, 26 March 2011, 19:26 GMT
can you send those patches upstream?
Comment by James (JRMoore) - Saturday, 26 March 2011, 20:20 GMT
The symbol visibility one is already applied in SVN, it's really to cleanup the exported symbols so that only the official API is accessible; not really an important one but to avoid using functions not in the API.

I extracted the pkg-config one from an openSUSE package, I'd send it upstream but I don't know the name of the original author (although with only 4 commits in 2010 it's quite an inactive project). It also contains a little change to install libgme on a multilib system successfully which was already reported as an issue in November [1] but has not received any comment.

[1]: http://code.google.com/p/game-music-emu/issues/detail?id=8
Comment by Jan de Groot (JGC) - Tuesday, 05 April 2011, 08:52 GMT
AFAIK upstream has both the visibility patches and the pkgconfig file in SVN. If I would implement this, I would just update to an svn snapshot.
I think upstream should release a new version with these changes. As long as upstream doesn't release a version with pkgconfig file in it, developers have no reason to use pkgconfig for libgme detection.

Loading...