FS#23295 - [aircrack-ng][aircrack-ng-scripts] have duplicated entry included

Attached to Project: Community Packages
Opened by Techlive Zheng (techlive) - Wednesday, 16 March 2011, 14:33 GMT
Last edited by Andrea Scarpino (BaSh) - Monday, 28 March 2011, 16:21 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Gavin Bisesi (Daenyth)
Brad Fanella (cesura)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

### Description:

The PKGBUILD 1.1-3 of aircrack-ng has split the source into two packages aircrack-ng and aircrack-ng-scripts which mean to seperate the scripts included.

###Additional info:

* package version(s) : 1.1-3
* config and/or log files etc : no

Run

> pacman -Ql aircrack-ng-scripts

We get

>> aircrack-ng-scripts /usr/bin/airmon-ng
>> aircrack-ng-scripts /usr/bin/airdriver-ng
>> aircrack-ng-scripts /usr/bin/airodump-ng-oui-update

And Run

> pacman -Ql aircrack-ng

We get

>> aircrack-ng /usr/sbin/airmon-ng
>> aircrack-ng /usr/sbin/airdriver-ng
>> aircrack-ng /usr/sbin/airodump-ng-oui-update

The above three scripts are exactly the same,and then i checked the PKGBUILD and the Makefile of aircrack.I found the Makefile in aircrack-ng scripts have already install the above three scripts when calling `make ... install` in functioan package_aircrack-ng,so the flowing lines in function package_aircrack-ng should be removed or commented.

> # airmon-ng
> # install -Dm644 airmon-ng ${pkgdir}/usr/bin/

> # airdriver-ng
> # install -Dm644 airdriver-ng ${pkgdir}/usr/bin/

> # airodump-ng-oui-update
> # install -Dm644 airodump-ng-oui-update ${pkgdir}/usr/bin/

At last,i suggest that it is better to seperate the scripts airdrop-ng and airgraph-ng as independent packages rather than seperate them all together as aircrack-ng-scripts for users will not no what exactly the scipts are if they are unfimiliar with aircrack-ng.I upload an updated PKGBUILD as attachment.

Also,I moved the lib_Airgraphviz.py form /usr/lib to /usr/lib/airgraph-ng.

Hope you can agree with me.

### Steps to reproduce
(application/x-gzip)    aircrack-ng-1.1-4.src.tar.gz (1.2 KiB)
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Monday, 28 March 2011, 16:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  aircrack-ng-1.1-5
Comment by Techlive Zheng (techlive) - Wednesday, 16 March 2011, 14:51 GMT
The 1.1-4 src tarball I attached in the bug report is broken,airdrop or airgraph cannot replaces the existed aircrack-ng-scriptsk,here is the new one.
(application/x-gzip)    aircrack-ng-1.1-4.src.tar.gz (1.2 KiB)
Comment by flo (flo) - Thursday, 17 March 2011, 04:05 GMT
latest aircrack-ng (aircrack-ng-1.1-4) package doesn't include airmon-ng.

airmon-ng is a script but he should be present in aircrack-ng package because he put the card in monitor mode (yes we can with iw but he also detect if you run a daemon who can crash aircrack)

Normaly you should only make in aircrack-ng-scripts airdrop-ng and airgraph-ng (because airdrop and airgraph need extra lib) and it's better to rename aircrack-ng-scripts by aircrack-ng-extra ...
Comment by Techlive Zheng (techlive) - Thursday, 17 March 2011, 04:32 GMT
The airmon-ng 1.1-4 attached in comment indeed contain the airmon-ng in /usr/sbin,please double check you installation.

I agreed with you to rename aircrack-ng-scripts to aircrack-ng-extra which only contain airdrop-ng and airgraph-ng,but make them into independent packages is also a good idea i think.
Comment by Techlive Zheng (techlive) - Thursday, 17 March 2011, 07:43 GMT
@flo

I haven't noticed that the TU had update the package in community yesteday simply by remove the airmon-ng,airdriver-ng,airodump-ng-oui-update without any update in this bug report.

Also,the usr/lib/airgraph-ng/ has been made,but the lib_Airgraphviz.py still in /usr/lib which should be placed in /usr/lib/airgraph-ng.
Comment by Techlive Zheng (techlive) - Friday, 18 March 2011, 06:35 GMT
In the latest aircrack-ng (aircrack-ng-1.1-4) in community still has airmon man pages in aircrack-ng,but the air-program is in aircrack-ng-scripts.How ugly it is.
Comment by Brad Fanella (cesura) - Saturday, 19 March 2011, 00:25 GMT
Sorry for the late reply, I have been sick for the past week.

I just pushed aircrack-ng-1.1-5 to community, and judging from their "pacman -Ql" outputs, they should be just fine.
Comment by Techlive Zheng (techlive) - Saturday, 19 March 2011, 17:54 GMT
Okay, seems all fine.

Also, maybe you should consider move airmon-ng airdriver-ng and airdump-oui-update into aircrack-ng package,and split the airdrop and airgraph into two seperate packages,because the project seems treat these two programs as two independent projects which has its own makefiles and dependency. And the airmon-ng in lots of distributions is packaged in aircrack-ng and mentioned by lots of aircrack toturials.Think about such a condition if someone from an other linux distribution install the Arch aircrack-ng package and can not find the airmon program, what will he think,and he will not kown there is an package called aircrack-ng-scripts contain the program airmon-ng. Otherwise, airdrop-ng and airgraph-ng is not that widely need,if someone needs,he will do some seach.Also,there are two PKGBUILDs called airgraph-svn and airdrop(which is acturally a svn PKGBUILD,should be renamed to airdrop-svn) in AUR.

After all, the current splition is okay,does not affect to much.

Please take care of you body, health is much more valuable than anything.

Best wishes.

Loading...