FS#23122 - [devtools] commitpkg: Abort properly if source files are not under version control

Attached to Project: Arch Linux
Opened by Lukas Fleischer (lfleischer) - Thursday, 03 March 2011, 13:38 GMT
Last edited by Pierre Schmitz (Pierre) - Saturday, 26 March 2011, 08:37 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Pierre Schmitz (Pierre)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
commitpkg shows the usual "${file} is not under version control" message if a source/ChangeLog/".install" file is not under version control but just continues committing as the version control checks are executed within a subshell and the abort() call only exits from that but doesn't cancel the package submission. Is that intended behaviour?

Additional info:
* devtools 0.9.17-1

Steps to reproduce:
`corepkg`/`extrapkg`/`communitypkg`/`multilibpkg` something without adding all source files with `svn add $foo` before.
This task depends upon

Closed by  Pierre Schmitz (Pierre)
Saturday, 26 March 2011, 08:37 GMT
Reason for closing:  Implemented
Comment by Lukas Fleischer (lfleischer) - Friday, 11 March 2011, 20:25 GMT
git-formatted patch attached.
   0001-Abort-properly-if-source... (1.6 KiB)

Loading...