FS#23081 - [wicd] remove bogus dependency on consolekit + in need of patch cleanup

Attached to Project: Arch Linux
Opened by Thomas Dziedzic (tomd123) - Monday, 28 February 2011, 21:02 GMT
Last edited by Isenmann Daniel (ise) - Sunday, 20 March 2011, 17:20 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Isenmann Daniel (ise)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

In response to  FS#19689  - [wicd] missing dependency on consolekit [1]:
upstream said that wicd should not depend on consolekit, the only reason consolekit was added was because of the above bug report

The solution of adding consolekit to the depends is at best a fix for a symptom of a much larger problem (dbus as was hinted in  FS#19689 )

Also, we apply a lot of patches, are these from upstream?

I have repackaged wicd for myself without consolekit and it works just fine.

* package version(s)
wicd 1.7.0-6

[1] - https://bugs.archlinux.org/task/19689
This task depends upon

Closed by  Isenmann Daniel (ise)
Sunday, 20 March 2011, 17:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  Removed consolekit dependency.
Comment by Isenmann Daniel (ise) - Tuesday, 01 March 2011, 06:27 GMT
We apply ONLY 2 patches and after I have looked through it, both are unnecessary. Both patches were applied upstream in 1.7.0, I have forgotten to remove it from the PKGBUILD, so I can remove them with a new release. They changed nothing in the code.

About the consolekit dependency let me have a deeper look into it and I will decide if I remove it from the dependency array.
Comment by Thomas Dziedzic (tomd123) - Tuesday, 01 March 2011, 06:50 GMT
"We apply ONLY 2 patches and after I have looked through it, both are unnecessary. Both patches were applied upstream in 1.7.0, I have forgotten to remove it from the PKGBUILD, so I can remove them with a new release. They changed nothing in the code."
Nice

"About the consolekit dependency let me have a deeper look into it and I will decide if I remove it from the dependency array."
ok, hopefully upstream is right :)

Loading...