FS#22995 - Reject packages with src or pkg directories.

Attached to Project: AUR web interface
Opened by Loui Chang (louipc) - Monday, 21 February 2011, 16:24 GMT
Last edited by Lukas Fleischer (lfleischer) - Wednesday, 09 March 2011, 17:13 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version 1.8.0
Due in Version 1.8.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Oftentimes these packages contain the build or upstream sources.
We can't rely on users to use makepkg --source properly to create packages.
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Wednesday, 09 March 2011, 17:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.8.1.
Comment by Dave Reisner (falconindy) - Monday, 21 February 2011, 16:35 GMT
Why not just reject any tarball with _any_ directory?
Comment by Lukas Fleischer (lfleischer) - Monday, 21 February 2011, 18:03 GMT
Yes, I'd say we can reject any tarballs with directories inside.
Comment by Lukas Fleischer (lfleischer) - Monday, 21 February 2011, 18:21 GMT
Pushed a fix to my working tree [1].

[1] http://git.cryptocrack.de/aur.git/commit/?id=4b2b8afb8aad83588cd9d0cf9af28acfb5d3bb74
Comment by Jelle van der Waa (jelly) - Monday, 21 February 2011, 22:32 GMT
we don't we also reject dotfiles?
Comment by Lukas Fleischer (lfleischer) - Tuesday, 22 February 2011, 08:54 GMT
jelly: Cause valid packages generated by makepkg(8) may contain dotfiles (even though it's bad style) whereas they may never contain subdirectories.
Comment by Lukas Fleischer (lfleischer) - Wednesday, 23 February 2011, 10:27 GMT
  • Field changed: Due in Version (Undecided → 1.9.0)
Implemented [1].

[1] http://projects.archlinux.org/aur.git/commit/?id=4b2b8afb8aad83588cd9d0cf9af28acfb5d3bb74

Loading...