FS#22671 - [xorg-xdm] new patch to add consolekit support

Attached to Project: Arch Linux
Opened by Ciriaco Garcia de Celis (cgarcia) - Sunday, 30 January 2011, 19:50 GMT
Last edited by Jan de Groot (JGC) - Tuesday, 11 October 2011, 21:28 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 9
Private No

Details

Description:

Since the latest upgrade to consolekit 0.4.3-1, desktops launched by xdm from the local console are not created as "local". This denies the usage of logout/shutdown from the desktop, and also mounting removable devices support, since all sessions are always considered remote. These problems could be avoided tweaking policykit and adding the user to the "power" group but that is not the proper solution.

Steps to reproduce:

Run ck-list-sessions in a terminal once logged from xdm (e.g. in xfce4) and "is-local" flag will be incorrectly reported as FALSE. This doesn't occurs if downgrading to previous consolekit-0.4.1-4 version.

Proposed patch:

There is a patch already integrated in SuSE, likely based in another patch submitted a long time ago to Fedora. I have included it in Arch Linux, updating our PKGBUILD (see attachment to this tasklist with the full package source updated). This patch adds consolekit support to xdm. The original patch comes from:

https://build.opensuse.org/package/view_file?file=xdm-consolekit.diff&package=xorg-x11&project=openSUSE%3A11.3%3AUpdate%3ATest&srcmd5=5e43d91b0bf84c8a82fc23b1cb550931

I only did a tiny change to the SuSE patch (by some reason the compiler didn't receive the USE_CONSOLEKIT define). Also, PKGBUILD now initially invokes autoconf to regenerate the configure script with support for the new --with-consolekit option.

Note that this upgrade adds xorg-xdm a new dependency with 'consolekit' package, which previously was not required. Also, launching XFCE from .xsession requires to remove 'ck-launch-session' since now the session is handled by xdm (as gdm already did) and only 'startxfce4' is required (the second nested and unnecessary session would not inherit the local flag, unless perhaps tweaking with pam configuration). I'll update the XFCE wiki once this patch is committed.
This task depends upon

Closed by  Jan de Groot (JGC)
Tuesday, 11 October 2011, 21:28 GMT
Reason for closing:  Implemented
Comment by Borromini (Borromini) - Monday, 31 January 2011, 21:32 GMT
Same problem here on my laptop (xdm) and on my AppleTV (where Xbmc is launched directly through inittab).
Comment by Andrew (lockie) - Saturday, 05 February 2011, 10:45 GMT
Seems to solve USB auto-mounting issues.
Comment by David J. Haines (dhaines) - Sunday, 15 May 2011, 15:26 GMT
The proposed 1.1.10-3 works for me wonderfully. No stability issues noticed whatsoever and gets the proverbial job done.

Any plans on making it official?
Comment by Jan de Groot (JGC) - Monday, 10 October 2011, 10:31 GMT
  • Field changed: Status (Assigned → Requires Testing)
1.1.11 in testing has this patch applied in a modified form. Please test this version, as a lot of changes have been made upstream in the meanwhile.

Loading...