FS#22610 - [thunar] PATCH use stock_copy instead of stock_folder-copy

Attached to Project: Arch Linux
Opened by Matthew Gyurgyik (pyther) - Wednesday, 26 January 2011, 20:55 GMT
Last edited by Andreas Radke (AndyRTR) - Sunday, 30 January 2011, 21:18 GMT
Task Type Feature Request
Category Upstream Bugs
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Thunar uses the stock_folder-copy icon for the new file transfer dialogue / systray icon. This results in the "unknown" icon from showing. Some distribution do ship stock_folder-copy. However, both the default gnome theme and gnome-icon-themes-extra do not contain the stock_folder-copy icon.

Here is the upstream bug report I created: http://bugzilla.xfce.org/show_bug.cgi?id=6851

Bug created 2010-11-17 (~2 months ago)
3 lines of code that get changed
The patch attached to that bug report simply replaces stock_folder-copy with stock_copy.

This is kinda an arch issue in the fact that we don't provide stock_folder-copy, however upstream should be using a standard icon that ships with gnome-icon-theme or gnome-icon-theme-extra.

I am requesting that we use this patch in our package.

Since I know we typically try to avoid patching upstream it doesn't matter to me if the patch gets applied, although it would be nice.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Sunday, 30 January 2011, 21:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  included in 1.2.1 release
Comment by Matthew Gyurgyik (pyther) - Wednesday, 26 January 2011, 22:36 GMT
I emailed the thunar dev, Jannis, and he decided to ship stock_folder-copy. He committed his changes in master: http://git.xfce.org/xfce/thunar/commit/?id=8f7a02c162880e48891ea5528e3513d71ef6105f

I still think it would be nice to apply this patch for this release or backport the above commit.

Loading...