FS#22459 - [btrfs-progs-unstable] PKGBUILD doesn't honour CFLAGS

Attached to Project: Arch Linux
Opened by Emil Renner Berthing (Esmil) - Sunday, 16 January 2011, 14:39 GMT
Last edited by Tobias Powalowski (tpowa) - Wednesday, 26 January 2011, 21:00 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The Makefile of btrfs-progs-unstable doesn't seem to honour the CFLAGS environment variable.
The following small change forces it to do so
(and gets rid of debugging info, which I don't think normal to have in Arch binaries):

diff --git a/PKGBUILD b/PKGBUILD
index ba7591c..d58680f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -15,8 +15,7 @@ build() {
cd $srcdir/$pkgname
# fix for building with new glibc, taken from fedora
patch -Np1 -i ../btrfs-progs-build-fixes.patch
- make all
- make convert
+ make CFLAGS="$CFLAGS" all convert
make prefix=$pkgdir/usr bindir=$pkgdir/sbin install
# fix manpage
mkdir -p $pkgdir/usr/share/


Additional info:
I looked at version 0.19.20100607-3 of the PKGBUILD.

Steps to reproduce:
Build the btrfs-progs-unstable package with custom CFLAGS set in your /etc/makepkg.conf
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Wednesday, 26 January 2011, 21:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.19.20101006

Loading...