Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#22397 - [mplayer] PKGBUILD doesn't honour CFLAGS and LDFLAGS
Attached to Project:
Arch Linux
Opened by Emil Renner Berthing (Esmil) - Tuesday, 11 January 2011, 12:58 GMT
Last edited by Ionut Biru (wonder) - Tuesday, 11 January 2011, 13:09 GMT
Opened by Emil Renner Berthing (Esmil) - Tuesday, 11 January 2011, 12:58 GMT
Last edited by Ionut Biru (wonder) - Tuesday, 11 January 2011, 13:09 GMT
|
DetailsDescription:
The mplayer build system doesn't support global CFLAGS and LDFLAGS environment variables. This, however, doesn't mean that they should be ignored completely. The following small change honours the custom flags set in /etc/makepkg.conf while still keeping the build system happy: diff --git a/PKGBUILD b/PKGBUILD index 115e95e..12d0667 100644 --- a/PKGBUILD +++ b/PKGBUILD @@ -20,13 +20,18 @@ md5sums=('b783223d0a175cb1d2f5bcdc99d2f781' 'd00874ccc644b7f43d6ef1c942fcef28') build() { - # Custom CFLAGS break the mplayer build + # Global CFLAGS and LDFLAGS break the mplayer build + _cflags="${CFLAGS//-O?}" + _cflags="${_cflags//-pipe}" + _ldflags="$LDFLAGS" unset CFLAGS LDFLAGS cd ${srcdir}/${pkgname} ./configure --prefix=/usr \ --enable-runtime-cpudetection \ + --extra-cflags="$_cflags" \ + --extra-ldflags="$_ldflags" \ --disable-gui \ --disable-arts \ --disable-liblzo \ Additional info: I looked at version 32663-1 of the the PKGBUILD. Steps to reproduce: Compile mplayer with custom CFLAGS or LDFLAGS set in /etc/makepkg.conf |
This task depends upon
Closed by Ionut Biru (wonder)
Tuesday, 11 January 2011, 13:09 GMT
Reason for closing: Not a bug
Additional comments about closing: upstream doesn't want us to use our flags
Tuesday, 11 January 2011, 13:09 GMT
Reason for closing: Not a bug
Additional comments about closing: upstream doesn't want us to use our flags