Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#22293 - [libfetch] PKGBUILD doesn't honour CFLAGS and LDFLAGS

Attached to Project: Arch Linux
Opened by Emil Renner Berthing (Esmil) - Monday, 03 January 2011, 17:15 GMT
Last edited by Dan McGee (toofishes) - Wednesday, 05 January 2011, 16:07 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The Makefile in the package doesn't honour the CFLAGS and LDFLAGS environment variables.
The attached patch is one way to fix it, but there are probably a more elegant solution.
I just can't think of it right now.

Additional info:
I'm using the 2.33-1 version of the PKGBUILD.

Steps to reproduce:
Compile libfetch with custom CFLAGS or LDFLAGS set in your /etc/makepkg.conf
   libfetch.patch (2.4 KiB)
This task depends upon

Closed by  Dan McGee (toofishes)
Wednesday, 05 January 2011, 16:07 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed on trunk
Comment by Emil Renner Berthing (Esmil) - Monday, 03 January 2011, 17:22 GMT
Wops, updated patch.
   libfetch.patch (2.4 KiB)
   libfetch.patch (2.4 KiB)
Comment by Dan McGee (toofishes) - Wednesday, 05 January 2011, 16:05 GMT
Why are you adding CFLAGS and LDFLAGS to every make line in all of these PKGBUILDs? That is 100% unnecessary.

Thanks for the ideas for the rest, I'm going to check in a refreshed Makefile incorporating some of this but not needing an extra variable.

Loading...