FS#22268 - [libreoffice] suggestions for building

Attached to Project: Arch Linux
Opened by Thomas Dziedzic (tomd123) - Friday, 31 December 2010, 17:10 GMT
Last edited by Andreas Radke (AndyRTR) - Monday, 03 January 2011, 18:12 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

My first gripe is that libreoffice makedepends on openjdk6 and java-runtime. This is redundant because openjdk provides java-runtime.

Next, I would like to see the PKGBUILD makedepend on java-environment rather then openjdk6 because you are able to choose which java you can have installed. I have built libreoffice fine with the jdk.

Lastly, one flag I always use during the ./configure step, is --disable-binfilter
The description for this is "Disables legacy binary file formats filters build."
A thread discussing this is:libreoffice@lists.freedesktop.org/msg01213.html"> http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg01213.html
It really is only there for compatibility reasons, and as mentioned, these documents are rare. Also having binfilter enabled does increase the build time substantially. So please consider disabling binfilter in the PKGBUILD.

Thanks.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Monday, 03 January 2011, 18:12 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed the java makedep. Keep binfilter setting disabled as requested here.
Comment by Andreas Radke (AndyRTR) - Friday, 31 December 2010, 17:41 GMT
java-runtime - see  FS#22152  - it's needed. for the makedepends I directly choose it because pacman doesn't allow to choose while installing the makedeps. no need to change it because it's the only jdk in our offical repos available for the devs at build time.

binfilter option - it's a feature some people would probably miss. can you give a comparison of build time and pkg size what we would gain removing it? if you can't I'm not going to change it that soon.

please one issue per report for the next time.
Comment by Thomas Dziedzic (tomd123) - Friday, 31 December 2010, 18:10 GMT
"java-runtime - see  FS#22152  - it's needed. for the makedepends I directly choose it because pacman doesn't allow to choose while installing the makedeps. no need to change it because it's the only jdk in our offical repos available for the devs at build time."
It's needed for the depends. openjdk6 already provides java-runtime, I don't see that bug report relating to this. I still stand by what I said. So you would just need to remove java-runtime from the makedepends then.

"binfilter option - it's a feature some people would probably miss. can you give a comparison of build time and pkg size what we would gain removing it? if you can't I'm not going to change it that soon."
I doubt people will miss this. The documents binfilter enables are ones created during the staroffice days. Anyone with any important documents in that format should have converted to a more modern format by now. I will try to get times and sizes later today.

"please one issue per report for the next time."
Just didn't want to spam the bug list with general gripe :P
Comment by Thomas Dziedzic (tomd123) - Saturday, 01 January 2011, 01:37 GMT
they are both the same time and size :/
debian repackages the binfilter stuff, and it suggests that it is about 8mb of size compressed. http://packages.debian.org/lenny/openoffice.org-filter-binfilter
I ill try to investigate this tomorro

real time: 197min
size: 116mb
Comment by Thomas Dziedzic (tomd123) - Sunday, 02 January 2011, 23:16 GMT
You kno hat? ArchLinux.patch provides an extra flag called Shrink hich Im guessing applies the --disable-binfilter, hich makes me think is the reason hy there is no difference. So I guess you can ignore that, arch as building ith binfilter disabled all along :)

As to the makedepends issue, just make a decision and this can be closed.
Comment by Andreas Radke (AndyRTR) - Monday, 03 January 2011, 18:11 GMT
I've committed the makedep java fix to trunk.

I've rechecked the binfilter setting: is not enabled in Arch! There's no enable switch in the PKGBUILD and our Arch default config sets to it to disable already for a long time: http://cgit.freedesktop.org/libreoffice/build/tree/distro-configs/ArchLinux.conf.in - that's why you don't see any difference in size and build time. The shrink section is something different and currently almost empty in LibO master: http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300/apply

Closing this now.

Loading...