Arch Linux

Ah, forgot that the shell might call its built-in test when not called with full path. What about explicitly using /usr/bin/test? That should always work and we already depend on coreutils anyway.

Shells that have a problem with [ ] also have a problem with $(), which is present in /etc/profile.

Why not just require POSIX conformance as a minimum? That way [] and $() can be used.

If you'd read test(1p), i.e. the POSIX manpage for test reachable with "man 1p test", you'd see that it even says results are unspecified if there is merely more than 4 arguments.
There is a section about "XSI-conformant" systems, talking about more complex rules defining the behaviour of -a and -o, and those might just work, but there is simply no objective advantage of those over using the _simple_ and safe-to-work && and ||.
Remember that 'test' is usually builtin and calling it many times won't cause slow-down. Even if /usr/bin/test would be called a bunch of times, it would probably be a nanosecond difference anyway.

Using /usr/bin/test explicitly doesn't make sense in my opinion. POSIX conformance as a minimum must obviously be, again in my opinion. Also, using && and || will of course work with /usr/bin/test too, so once again, it's just fail-proof.

Even though I haven't found a shell having a problem with this in our repos it is probably more safe to use && here. Thanks for looking into this.