FS#21233 - [abs] fails with "rsync error: syntax or usage error"

Attached to Project: Arch Linux
Opened by Nicolas Bigaouette (big_gie) - Wednesday, 13 October 2010, 13:09 GMT
Last edited by Allan McRae (Allan) - Friday, 03 December 2010, 11:36 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
I can't sync abs anymore:
$ sudo abs
==> Starting ABS sync...
Unexpected remote arg: rsync.archlinux.org::abs/x86_64/
rsync error: syntax or usage error (code 1) at main.c(1204) [sender=3.0.7]

I tried a tarball too:
$ sudo abs -t
==> Downloading tarballs...
==> core...
==> ERROR: Download failed
[...]

Additional info:
* package version(s)
abs 2.3.4.1-1
rsync 3.0.7-1
pacman 3.4.1-1


I checked /usr/bin/abs and found the problem. The environment variable "INCLUDE" is set by the intel compiler to /opt/intel/Compiler/11.1/072/ipp/em64t/include:/opt/intel/Compiler/11.1/072/mkl/include. This breaks the rsync command:
rsync -mrtv --no-motd --delete-after --no-p --no-o --no-g --delete-excluded /opt/intel/Compiler/11.1/072/ipp/em64t/include:/opt/intel/Compiler/11.1/072/mkl/include --filter=P_/local/ --filter=P_/README rsync.archlinux.org::abs/{x86_64,any}/ /var/abs/

Clearing INCLUDE just before the if fixed it:
--- /usr/bin/abs.orig 2010-01-25 08:05:37.000000000 -0500
+++ /usr/bin/abs 2010-10-13 09:08:10.286667076 -0400
@@ -103,6 +103,7 @@
update_rsync() {
cd "$ABSROOT"

+ INCLUDE=""
if [ "$CLPARAM" = "" ]; then
# using repos specified in abs.conf
for repo in "${REPOS[@]}"; do

Any reason to NOT clear the variable?
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 03 December 2010, 11:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  http://projects.archlinux.org/abs.git/co mmit/?id=35ad63bd
Comment by Jan de Groot (JGC) - Wednesday, 13 October 2010, 17:49 GMT
Same for EXCLUDE. abs should clear variables before using them.

Loading...