FS#20999 - [avahi] systemd unit files are installed in improper location

Attached to Project: Arch Linux
Opened by Dave Reisner (falconindy) - Thursday, 30 September 2010, 12:50 GMT
Last edited by Gaetan Bisson (vesath) - Sunday, 03 October 2010, 11:41 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Gaetan Bisson (vesath)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Avahi's ./configure options specify to build --with-systemdsystemunitdir, but uses the path /usr/share/dbus-1/system-services/. This is not the recommended upstream location, as evidenced here:

http://www.freedesktop.org/wiki/Software/systemd/FrequentlyAskedQuestions

If this flag is going to be included, please use /lib/systemd/system as the unit dir.
This task depends upon

Closed by  Gaetan Bisson (vesath)
Sunday, 03 October 2010, 11:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in testing and staging
Comment by Ionut Biru (wonder) - Thursday, 30 September 2010, 12:56 GMT
that option was added because of  FS#20519 
Comment by Tom Gundersen (tomegun) - Thursday, 30 September 2010, 13:46 GMT
A suggestion:

Would it be possible to compile with "--with-systemdsystemunitdir=/lib/systemd/system", and then (until the bug is fixed) copy the required files from /lib/systemd/system to /usr/share/dbus-1/system-services/?

On a side note: is there not a chance of some unwanted side-effects of having systemd service files mixed up with the dbus services files? A priori these are very different....
Comment by Jan de Groot (JGC) - Thursday, 30 September 2010, 14:39 GMT
The systemd options passed to avahi are plain wrong, as it installs systemd files in the dbus system.d service directory. It seems systemd servicefiles are somewhat compatible with dbus, but the fact that it works is just a coincidence.
Avahi should have --with-dbus-sys passed to set the correct dbus path. Systemd is not officially supported in arch, so I see no reason to pass anything for that.
Comment by Ionut Biru (wonder) - Thursday, 30 September 2010, 14:48 GMT
--with-dbus-sys is the location where the conf is copied and not the service one
Comment by Dave Reisner (falconindy) - Thursday, 30 September 2010, 14:55 GMT
I think this may be an upstream issue. The .service file for the bus should always be generated (see other packages like gconf and polkit), but without the need for generating the other systemd unit files. I'm checking with upstream to see if this is the correct behavior.
Comment by Gaetan Bisson (vesath) - Thursday, 30 September 2010, 20:01 GMT
As Ionut said, the with-systemdsystemunitdir option is just here to fix  FS#20519  for the time being; for this purpose, its value doesn't matter, so we might as well use the recommended one.
I have commited a new version to SVN which does that. Feel free to disagree. Otherwise, in a few days, I'll upload packages.
Jan: I had to patch your introspection patch to get avahi to compile; please make sure you agree with my change.

Loading...