Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#20797 - [sqlite3] Please compile with SQLITE_SECURE_DELETE

Attached to Project: Arch Linux
Opened by Hussam Al-Tayeb (hussam) - Thursday, 09 September 2010, 22:20 GMT
Last edited by Andreas Radke (AndyRTR) - Friday, 10 December 2010, 19:21 GMT
Task Type Feature Request
Category Packages: Core
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

I compiled sqlite3 with -DSQLITE_SECURE_DELETE flag and afterwards, xulrunner/firefox 3.6.9 compiled and ran fine against system sqlite3 without any performance regression. I'm not sure if other applications that sqlite3 will be affected but if not, this would be a nice addition.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Friday, 10 December 2010, 19:21 GMT
Reason for closing:  Implemented
Additional comments about closing:  implemented in 3.7.4-1
Comment by Hussam Al-Tayeb (hussam) - Thursday, 09 September 2010, 22:23 GMT
by "applications that sqlite3" I meant "applications that use sqlite3". sorry for typo.
Comment by Andreas Radke (AndyRTR) - Saturday, 11 September 2010, 10:52 GMT
Usually we ship plain vanilla versions. What important reason do you have to enable it? I have only found recent changes in the log for Fedora spec that it would be probably needed by FF4 that is still months away:

http://pkgs.fedoraproject.org/gitweb/?p=sqlite.git;a=blob;f=sqlite.spec;h=13c447a94bbee7d6fc78fe6a2efa20ef747c10bb;hb=master
Comment by Hussam Al-Tayeb (hussam) - Saturday, 11 September 2010, 11:11 GMT
We already add non-default cflags to the sqlite3 PKGBUILD so it's already not sticking to vanilla default options.
export CFLAGS="$CFLAGS -DSQLITE_ENABLE_FTS3=1 -DSQLITE_ENABLE_COLUMN_METADATA=1 -DSQLITE_ENABLE_UNLOCK_NOTIFY"

Firefox 3.6.9 also requires this flag (3.6.8 didn't).

The open possible problem I see with this flag is a slight performance regression. this option makes sqlite3 zero out space when deleting data. I haven't seen any performance regression in firefox but I can't tell about other applications.
Comment by Hussam Al-Tayeb (hussam) - Friday, 08 October 2010, 19:13 GMT
For clarification, with this flag, xulrunner/firefox 3.6.10 and 4 will build correctly against system sqlite3 and will work fine. I've been using this for long months now.

Loading...