Arch Linux

Hugo has been MIA for months, not sure at all why this got assigned to him.

Implemented in http://projects.archlinux.org/users/remy/namcap.git/commit/?id=08caa0
Please provide any needed comments.

$ namcap picasa-beta-3.0_5744.02-3-x86_64.pkg.tar.xz PKGBUILD
picasa-beta W: File name opt/google/picasa/3.0/wine/drive_c/Program Files contains non standard characters
...

That seems a bit strict, no? Spaces have a valid case in some paths.

As a first try I chose to allow ASCII printable characters that do not have a special meaning in bash (except for several of them that I found in existing packages). I think adding space to the allowed characters is unharmful, but still I think it deserves some warning, at least to try to prevent upstream inserting spaces in filenames. Do you think differently ?

I think totally differently, yes, especially since you already made exceptions for most other punctuation characters. The only request here was non-ascii, not anything else. I think the check should stick to this and not try to whitelist/blacklist, but at the very least, I'm not sure how a space is any more suspect than { or }.

Also note that this warning is overwhelming in this package's case, and it isn't the only package in this boat:
$ pacman -Qlq picasa-beta | grep ' ' | wc -l
610
$ pacman -Qlq | grep ' ' | wc -l
1499

Especially vs. other characters you are currently excluding:
$ pacman -Qlq | grep '{' | wc -l
8
$ pacman -Qlq | grep '!' | wc -l
3

That's fine for me, since I had no real reason to exclude these, except for sticking to some tradition. Do we still agree on sticking with printable characters and excluding \r and \n for example ?

Seems fine with me.