Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#20731 - [nbd] new init script and config

Attached to Project: Community Packages
Opened by Christian Hesse (eworm) - Friday, 03 September 2010, 10:41 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 30 May 2011, 08:22 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
nbd-server is supposed to work with a config file in /etc/nbd-server/ since
version 2.9. I changed the package to reflect the new requirements.
I attached the changed files.

Additional info:
* package version: 2.9.18-1
   nbd (0.7 KiB)
   config (0.2 KiB)
   PKGBUILD (1 KiB)
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Monday, 30 May 2011, 08:22 GMT
Reason for closing:  Implemented
Comment by Christian Hesse (eworm) - Saturday, 28 May 2011, 21:22 GMT
Ok, prepared a patch against 2.9.21a-1.
   nbd.patch (3.4 KiB)
Comment by Sven-Hendrik Haase (Svenstaro) - Sunday, 29 May 2011, 05:09 GMT
A few notes:

Why did you put the oldstyle in there?

You didn't create the user nbd.

I feel like we shouldn't alter the default config given in the README, so no [archiso].

.22 will be out this weekend. Can you make a new patch with the updated changes with the update?

Comment by Christian Hesse (eworm) - Sunday, 29 May 2011, 16:55 GMT
> Why did you put the oldstyle in there?

I think I still need this for System Rescue CD (http://sysresccd.org/) via PXE. I can remove that if you prefer the plain example from package.

> You didn't create the user nbd.

I've set it to nobody on my system... ;)
I will add the user for my next patch.

> I feel like we shouldn't alter the default config given in the README, so no [archiso].

Ok.

> .22 will be out this weekend. Can you make a new patch with the updated changes with the update?

Shure!

The package does not include the README, is it ok to include it as /usr/share/docs/nbd/README(.gz)?
Comment by Sven-Hendrik Haase (Svenstaro) - Sunday, 29 May 2011, 17:59 GMT
Don't the manpages cover everything? I mean if we include the config we might as well include the README but perhaps it is simply redundant?
Comment by Christian Hesse (eworm) - Monday, 30 May 2011, 06:41 GMT
Ok, here's the patch for 2.9.22.

I includes the README now. The README gives a package overview and has the config we want to deliver by default, so it makes sense to include it I think.

I added user and group 'nbd'. Without a given uid and gid the system uses anything above 1000... Is there any way to 'register' new fixed ids for Arch?
   nbd.patch (4 KiB)
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 30 May 2011, 07:49 GMT
Thanks for the patch. I fixed the user uid stuff. Basically, you pick a user id, search abs for any conflicts, and then go with it.
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 30 May 2011, 08:17 GMT
Pushed, please try it out.

Loading...