FS#20619 - [kernel26] i8k module

Attached to Project: Arch Linux
Opened by Nick Sudden (nick_sudden) - Thursday, 26 August 2010, 11:57 GMT
Last edited by Andrea Scarpino (BaSh) - Saturday, 07 May 2011, 00:43 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Tobias Powalowski (tpowa)
Thomas Bächler (brain0)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Reporting to this discussion (https://bbs.archlinux.org/viewtopic.php?pid=783733), the i8k module integrated into latests kernel doesn't work correctly.


Here's the patch :

diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
index 4cd8b22..c2eaa02 100644
--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -119,7 +119,7 @@ static int i8k_smm(struct smm_regs *regs)
int eax = regs->eax;

#if defined(CONFIG_X86_64)
- asm("pushq %%rax\n\t"
+ asm volatile("pushq %%rax\n\t"
"movl 0(%%rax),%%edx\n\t"
"pushq %%rdx\n\t"
"movl 4(%%rax),%%ebx\n\t"
@@ -145,7 +145,7 @@ static int i8k_smm(struct smm_regs *regs)
: "a"(regs)
: "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory");
#else
- asm("pushl %%eax\n\t"
+ asm volatile("pushl %%eax\n\t"
"movl 0(%%eax),%%edx\n\t"
"push %%edx\n\t"
"movl 4(%%eax),%%ebx\n\t"
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Saturday, 07 May 2011, 00:43 GMT
Reason for closing:  Fixed
Additional comments about closing:  kernel26 2.6.38.5-1
Comment by Gerardo Exequiel Pozzi (djgera) - Thursday, 26 August 2010, 15:27 GMT
Is this already reported to upstream? If not please report it. Please add Linux version.
Please use attachs next time.
Comment by Nick Sudden (nick_sudden) - Thursday, 26 August 2010, 16:08 GMT
Yes it is reported upstream (https://bugzilla.kernel.org/show_bug.cgi?id=16280)
Original file is here (https://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=drivers/char/i8k.c;hb=HEAD)
Comment by JM (fijam) - Tuesday, 03 May 2011, 13:31 GMT
Upstream bug marked as Fixed. Please confirm so this bug can be closed.
Comment by orbisvicis (orbisvicis) - Friday, 06 May 2011, 19:40 GMT
Fixed for me - 2.6.38. The i8k module is loaded and I am running i8kmon.

Loading...