FS#20498 - repo-add: creates absolute symlinks to db file

Attached to Project: Pacman
Opened by Pierre Schmitz (Pierre) - Tuesday, 17 August 2010, 18:16 GMT
Last edited by Dan McGee (toofishes) - Wednesday, 18 August 2010, 18:45 GMT
Task Type Bug Report
Category Scripts & Tools
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Medium
Priority Normal
Reported Version 3.4.0
Due in Version 3.4.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

repo-add creates a symlink called $repo.db to the specific file to support different compression types. Unfortunatly these symlinks are absolute and as such broken on every mirror that does not match our file system layout.

See http://projects.archlinux.org/pacman.git/tree/scripts/repo-add.sh.in#n491

Suggestion: Use $(basename "$REPO_DB_FILE")
This task depends upon

Closed by  Dan McGee (toofishes)
Wednesday, 18 August 2010, 18:45 GMT
Reason for closing:  Fixed
Comment by Dan McGee (toofishes) - Tuesday, 17 August 2010, 18:19 GMT
Allan broke it! Suggestion seems reasonable though.
Comment by Allan McRae (Allan) - Tuesday, 17 August 2010, 21:58 GMT
This took me ages to figure out why there was an issue! It only matters when someone passes a full path to the db as the first argument of repo-add. I have always run it from the directory the database will be in so could not figure out how you were getting a path there.

Anyway, I'd prefer a bash string manipulation over basename. Otherwise fine.

Loading...