FS#20496 - netpbm wrong includes

Attached to Project: Arch Linux
Opened by Lukas Jirkovsky (6xx) - Tuesday, 17 August 2010, 09:57 GMT
Last edited by Eric Belanger (Snowman) - Thursday, 19 August 2010, 02:47 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
when trying to compile package using netpbm's ppm.h build fails with:

/usr/include/ppm.h:6:23: fatal error: netpbm/pm.h: No such file or directory
compilation terminated.

The problem is that ppm.h uses #include <netpbm/pm.h> and #include <netpbm/pgm.h> but these are in /usr/include/pm.h resp. /usr/include/pgm.h, not in /usr/include/netpbm
This task depends upon

Closed by  Eric Belanger (Snowman)
Thursday, 19 August 2010, 02:47 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in netpbm-10.47.18-1
Comment by Ionut Biru (wonder) - Tuesday, 17 August 2010, 20:14 GMT
==> Finished making: netpbm 10.47.16-1 (Wed Aug 18 06:02:55 UTC 2010)


sorry i can't replicate this issue
Comment by Lukas Jirkovsky (6xx) - Wednesday, 18 August 2010, 08:12 GMT
Ionut: The problem is not with making the netpbm package but with packages using netpbm. I noticed it when building pfstools from AUR (http://aur.archlinux.org/packages.php?ID=7552). The curent PKGBUILD has netpbm support disabled beacuse of this, but it can be enabled (look at the commented parts). In fact any code using netpbm headers will fail (at least what I've seen).

You can test it by compiling this simple C source:

#include <ppm.h>

int main() {
printf("foo");
return 0;
}
Comment by Lukas Jirkovsky (6xx) - Wednesday, 18 August 2010, 08:17 GMT
Simple fix.
   change_include_dir.diff (1 KiB)
Comment by Ionut Biru (wonder) - Wednesday, 18 August 2010, 08:59 GMT
i didn't understood the first time sorry.

Eric, you updated this package and added those sed lines. I guess is because of:
sed -i 's|include/netpbm|include|' GNUmakefile lib/Makefile
Comment by Lukas Jirkovsky (6xx) - Wednesday, 18 August 2010, 09:07 GMT
Ionut: yep, when it's removed everything works fine.

Loading...