FS#20350 - [abs] Update prototypes

Attached to Project: Arch Linux
Opened by Sven-Hendrik Haase (Svenstaro) - Tuesday, 03 August 2010, 17:15 GMT
Last edited by Allan McRae (Allan) - Saturday, 02 October 2010, 06:39 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Most prototypes of abs are currently outdated and do not reflect recent changes of makepkg.

1) build() {} and package() {} should be separate.
2) No || return 1 safe guards required any more.
3) Contributor should be changed to Maintainer

As far as I can see, only PKGBUILD.proto and PKGBUILD-split.proto are up to date.
This task depends upon

Closed by  Allan McRae (Allan)
Saturday, 02 October 2010, 06:39 GMT
Reason for closing:  Implemented
Additional comments about closing:  git commits 667b058c and b4ab9413
Comment by PyroPeter (pyropeter) - Saturday, 18 September 2010, 16:29 GMT
Patch attached, fixes 1. and 3. (2. was already fixed by Allan)
   0001-Bug-20350-Update-prototy... (7.9 KiB)
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 24 September 2010, 05:13 GMT
You should probably also post the patch to the mailing list.
Comment by Allan McRae (Allan) - Friday, 24 September 2010, 05:15 GMT
No point. I deal with ABS and this is assigned to me.
Comment by solsTiCe (zebul666) - Saturday, 25 September 2010, 17:56 GMT
may be an abs 2.3.4.2 could be released. not much of a change but the last one is from january ?
Comment by Allan McRae (Allan) - Saturday, 25 September 2010, 22:56 GMT
I intend to get 2.4.0 out soon as there are a couple of other bug fixes that need added. But I have been making those plans for months but they get delayed due to many other higher priority tasks...
Comment by Allan McRae (Allan) - Saturday, 02 October 2010, 06:17 GMT
As an FYI, that patch breaks every prototype...

Pushing a fixed version now.
Comment by Allan McRae (Allan) - Saturday, 02 October 2010, 06:39 GMT
contributor -> maintainer: http://projects.archlinux.org/abs.git/commit/?id=b4ab9413
package(): http://projects.archlinux.org/abs.git/commit/?id=667b058c

Loading...