Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#20343 - [udev] improvements to root-link.sh

Attached to Project: Arch Linux
Opened by Dave Reisner (falconindy) - Monday, 02 August 2010, 19:38 GMT
Last edited by Tobias Powalowski (tpowa) - Sunday, 29 August 2010, 11:35 GMT
Task Type Feature Request
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

root-link.sh is an extremely simple script that only serves to create a symlink to /dev/root based on the root parameter passed in the bootloader. However, it invokes invokes 3 subshells where a single sed expression would suffice. I'd also like to suggest that the root device be checked to see if it's a symlink, resolving it if it is. The updated script is attached.
   root-link.sh (0.2 KiB)
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Sunday, 29 August 2010, 11:35 GMT
Reason for closing:  Fixed
Additional comments about closing:  161-1
Comment by Roman Kyrylych (Romashka) - Monday, 02 August 2010, 19:59 GMT
Haven't checked if it works yet, but looks good to me.
Comment by Thomas Bächler (brain0) - Monday, 02 August 2010, 20:58 GMT
root-link.sh is broken and this doesn't fix it. I vote for the removal of this entirely useless and broken feature.
Comment by Roman Kyrylych (Romashka) - Monday, 02 August 2010, 21:00 GMT
What do you mean by "broken"? It doesn't work in some cases?
And "useless" - are issues related to the absence of /dev/root now gone?
Comment by Thomas Bächler (brain0) - Monday, 02 August 2010, 21:10 GMT
Sorry, I should have been more detailed. The script assumes that root= on the command line corresponds to the real root device, an assumption which is often wrong.

About the /dev/root link being needed - kinit used to mount /dev/root in many cases which was then in /proc/mounts. Broken applications used to read /proc/mounts instead of /etc/mtab, the root-link.sh was an attempt to fix that in the wrong place.
Comment by Dave Reisner (falconindy) - Monday, 02 August 2010, 21:17 GMT
Removing it entirely works too! My goal here was just to cut back on the number of processes spawned. Suppose I should have Googled around to see that /dev/root is somewhat of a relic...
Comment by Roman Kyrylych (Romashka) - Monday, 02 August 2010, 21:21 GMT
Thanks for explanation, Thomas.
That makes sense.
Comment by Thomas Bächler (brain0) - Monday, 02 August 2010, 21:32 GMT
http://repos.archlinux.org/wsvn/packages?op=comp&compare[]=%2Fudev%2Ftrunk@85643&compare[]=%2Fudev%2Ftrunk@86660

Loading...