Pacman

Historical bug tracker for the Pacman package manager.

The pacman bug tracker has moved to gitlab:
https://gitlab.archlinux.org/pacman/pacman/-/issues

This tracker remains open for interaction with historical bugs during the transition period. Any new bugs reports will be closed without further action.
Tasklist

FS#20272 - Repackaging fails when multiple packages are passed to --pkg

Attached to Project: Pacman
Opened by Dave Reisner (falconindy) - Saturday, 24 July 2010, 21:14 GMT
Last edited by Allan McRae (Allan) - Thursday, 29 July 2010, 10:59 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Medium
Priority Normal
Reported Version git
Due in Version 3.4.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Steps to reproduce:
1) Build a split package (tested with kernel26 and vim)
2) Issue a makepkg command with multiple args to --pkg such as: makepkg -Rf --pkg "gvim vim-runtime"

Root cause:
PKGLIST is handled as a simple string in some places (lines 76 and 1607), and as an array in others (lines 1288, 1289, 1818, and 1820). In addition, on line 1820, pkgname is declared as a simple string, and then iterated over as if it were an array on line 1839.

Fix: Always treat PKGLIST as an array and define pkgname as an array when assigning the contents of PKGLIST. Patch attached.

   0001-Always-treat-PKGLIST-as-... (1.3 KiB)
This task depends upon

Closed by  Allan McRae (Allan)
Thursday, 29 July 2010, 10:59 GMT
Reason for closing:  Not a bug
Additional comments about closing:  Original report was not a bug. Issue in comments has be addressed
Comment by Dave Reisner (falconindy) - Saturday, 24 July 2010, 21:23 GMT
Not sure if this should stay open or not... I was getting false positives from PKGBUILDs that are not arbitrarily re-entrant (e.g. vim or kernel26) via the --pkg option, but its not an issue of makepkg. Still, I'm wondering if the differening declarations of PKGLIST and pkgname are intentional.
Comment by Allan McRae (Allan) - Sunday, 25 July 2010, 06:36 GMT
Thanks. Pushed my working branch.

The reason for the inconsistency between array/string declarations is that it really does not matter and no-one has been concerned enough to change it. That and pkgname is a string for a single package and an array for a split package...
Comment by Allan McRae (Allan) - Thursday, 29 July 2010, 10:58 GMT
Patch applied: http://projects.archlinux.org/pacman.git/commit/?h=maint&id=7f5c4866

Loading...