FS#20272 - Repackaging fails when multiple packages are passed to --pkg
Attached to Project:
Pacman
Opened by Dave Reisner (falconindy) - Saturday, 24 July 2010, 21:14 GMT
Last edited by Allan McRae (Allan) - Thursday, 29 July 2010, 10:59 GMT
Opened by Dave Reisner (falconindy) - Saturday, 24 July 2010, 21:14 GMT
Last edited by Allan McRae (Allan) - Thursday, 29 July 2010, 10:59 GMT
|
Details
Steps to reproduce:
1) Build a split package (tested with kernel26 and vim) 2) Issue a makepkg command with multiple args to --pkg such as: makepkg -Rf --pkg "gvim vim-runtime" Root cause: PKGLIST is handled as a simple string in some places (lines 76 and 1607), and as an array in others (lines 1288, 1289, 1818, and 1820). In addition, on line 1820, pkgname is declared as a simple string, and then iterated over as if it were an array on line 1839. Fix: Always treat PKGLIST as an array and define pkgname as an array when assigning the contents of PKGLIST. Patch attached. 
0001-Always-treat-PKGLIST-as-...
(1.3 KiB)
|
This task depends upon
Closed by Allan McRae (Allan)
Thursday, 29 July 2010, 10:59 GMT
Reason for closing: Not a bug
Additional comments about closing: Original report was not a bug. Issue in comments has be addressed
Thursday, 29 July 2010, 10:59 GMT
Reason for closing: Not a bug
Additional comments about closing: Original report was not a bug. Issue in comments has be addressed
The reason for the inconsistency between array/string declarations is that it really does not matter and no-one has been concerned enough to change it. That and pkgname is a string for a single package and an array for a split package...