FS#20182 - [openstreetmap-map-icons-svn] - PKGBUILD syntax

Attached to Project: Community Packages
Opened by orbisvicis (orbisvicis) - Wednesday, 14 July 2010, 22:02 GMT
Last edited by Thomas Dziedzic (tomd123) - Thursday, 15 July 2010, 18:54 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

PKGBUILD could have either been:
{
# comments
command &&
command &&
} || return

--or--
command || return 1
command || return 1

Since the grouping command shell ({}) is removed I suggest you revert back to the second form in order to abort upon error during the makepkg build.

Additional info:
openstreetmap-map-icons-svn 21934-1
This task depends upon

Closed by  Thomas Dziedzic (tomd123)
Thursday, 15 July 2010, 18:54 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in trunk
Comment by Thomas Dziedzic (tomd123) - Wednesday, 14 July 2010, 22:23 GMT
ya, I don't like all those && but he doesn't need " || return 1"s
Comment by orbisvicis (orbisvicis) - Thursday, 15 July 2010, 02:30 GMT
yeah good point

Loading...