FS#20101 - [pcmanfm] Include gvfs as optdepends

Attached to Project: Community Packages
Opened by Kevin (anonymous_user) - Wednesday, 07 July 2010, 19:58 GMT
Last edited by Ionut Biru (wonder) - Saturday, 27 August 2011, 07:39 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jürgen Hötzel (juergen)
Angel Velasquez (angvp)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

The new PCManFM needs gvfs for trash bin support as well as volume management. In addition, PCManFM needs to be launched as dbus-launch pcmanfm for the features to work.
This task depends upon

Closed by  Ionut Biru (wonder)
Saturday, 27 August 2011, 07:39 GMT
Reason for closing:  Not a bug
Additional comments about closing:  https://bugs.archlinux.org/task/20101#co mment81984
Comment by Alois Nespor (anespor) - Monday, 02 August 2010, 08:25 GMT
'gvfs' is NOT needed yet. PCManFM2 need 'udisk'

http://blog.lxde.org/?p=768
Comment by Kevin (anonymous_user) - Monday, 02 August 2010, 13:55 GMT
I do not know why I wrote that, but gvfs is still needed for trash bin support at least.
Comment by Alois Nespor (anespor) - Thursday, 02 September 2010, 14:19 GMT
pcmanfm need also consokit for mounting CD/DVD, can be also as optdepend.

Without consolekit are mounting CD/DVD/flash/SD card "Not authorized" (I use slim, openbox, polkit, udev, dbus and now consolekit)
Comment by Robert Petranovic (jazzfan) - Sunday, 21 August 2011, 10:10 GMT
There are some incorrect informations in past posts.

Neither consolekit nor gvfs are needed for volume management!
I don't even have those two installed, just udisk, and volume management works fine.

It is true that trash icon appears only when using gvfs, but who would install whole gvfs just to get a trash can?

I would put only udisk as optdepend.
Comment by Jakob Matthes (jakobm) - Sunday, 21 August 2011, 11:43 GMT
Consider that pcmanfm depends on libfm:
If libfm is build with udisks support, libfm should depend on udisks.
pcmanfm does not need to depend on udisks, as it depends on libfm.

gvfs is listed as an optional dependency:
http://wiki.lxde.org/en/PCManFM_build_and_setup_guide#Setup_Runtime_Environment_Correctly
I'm not sure about the status of that wiki page.

Should libfm or pcmanfm list gvfs as an optdepend?
Comment by Mihai Militaru (akephalos) - Sunday, 21 August 2011, 13:38 GMT
gvfs provides additional functionality but it is not required, pcmanfm/libfm was modified by the developer on purpose to not depend on it. Adding it as optdepend (say 'gvfs: trash support') is the way to go based on the Arch guidelines.

Regarding where should the optdepend be added, grepping the pcmanfm extracted tarball for "gvfs" returns nothing, while libfm returns quite several hits. Both return references to GIO, including in the actual source code. You draw a conclusion, I think both make use of it at this point. I checked both the Arch versions (pcmanfm-0.9.8 and libfm-0.1.4) and the developer last versions (0.9.9 and respectively 0.1.6).

Loading...