FS#19748 - [makepkg] --allsource and --source now only has soft links for local files
Attached to Project:
Pacman
Opened by christopher rogers (godane) - Wednesday, 09 June 2010, 00:05 GMT
Last edited by Allan McRae (Allan) - Wednesday, 09 June 2010, 16:24 GMT
Opened by christopher rogers (godane) - Wednesday, 09 June 2010, 00:05 GMT
Last edited by Allan McRae (Allan) - Wednesday, 09 June 2010, 16:24 GMT
|
Details
Summary and Info:
The new makepkg in pacman git repo only has soft links for local files when making .src.tar.gz. This is only a problem with files with no urls. Like example the config file for kernel26 or the .install files. Steps to Reproduce: install new makepkg from pacman git repo sudo abs cd /var/abs/core/kernel26 makepkg --allsource --asroot or makepkg --source --asroot Then extract the .src.tar.gz This happens in user too. |
This task depends upon
Closed by Allan McRae (Allan)
Wednesday, 09 June 2010, 16:24 GMT
Reason for closing: Fixed
Additional comments about closing: git commits ac5c2fd0 and b8863622
Wednesday, 09 June 2010, 16:24 GMT
Reason for closing: Fixed
Additional comments about closing: git commits ac5c2fd0 and b8863622
I'm assuming this blocks the release, so I'm going to mark it as such for now.
eval file='${srclinks}/${pkgbase}/'${file}
to this:
eval file=${file}
It made no since to have done any other way. It would be the soft link pointing to itself.
I added my git format patch. I hope this helps.
This is the only change needed:
- ln -s "$file" "$srclinks/$pkgbase"
+ ln -s "$startdir/$file" "$srclinks/$pkgbase"
Damn... I should have caught both of these during patch review.
I think there is a another bug also. I think makepkg only like one .install file. I get this error with gcc:
/usr/bin/makepkg: line 1109: local: `gcc.install': not a valid identifier
/usr/bin/makepkg: line 1109: local: `gcc-fortran.install': not a valid identifier
/usr/bin/makepkg: line 1109: local: `gcc-ada.install': not a valid identifier
i hope this helps.