FS#19730 - [go] Godoc does not work after default install

Attached to Project: Community Packages
Opened by Stephen Weinberg (stephenmw) - Sunday, 06 June 2010, 19:40 GMT
Last edited by Vesa Kaihlavirta (vegai) - Monday, 30 May 2011, 12:28 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Vesa Kaihlavirta (vegai)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:

Godoc from the package go does not work. This is fixed in aur/go-lang-hg by just placing the file there.

Additional info:
* package version(s)
go all versions

Steps to reproduce:

$ godoc -http=:6060
2010/06/06 15:34:46 ReadFile /usr/lib/go/lib/godoc/dirlist.html: open /usr/lib/go/lib/godoc/dirlist.html: no such file or directory
This task depends upon

Closed by  Vesa Kaihlavirta (vegai)
Monday, 30 May 2011, 12:28 GMT
Reason for closing:  Fixed
Comment by Stephen Weinberg (stephenmw) - Sunday, 04 July 2010, 01:22 GMT
Just an update, aur/go-lang-hg was renamed to go-hg.

I hope this is fixed soon.
Comment by Robert Ransom (rransom) - Tuesday, 17 August 2010, 00:16 GMT
The attached PKGBUILD:

* increments pkgrel
* should fix  FS#20267 
* partially fixes this bug (the /usr/lib/go/doc -> /usr/share/go/doc symlink is part of this fix); godoc still doesn't serve package documentation
* removes the warning about the build failing if Go is already installed; it worked for me
* removes more unnecessary whitespace
   PKGBUILD (2.3 KiB)
   PKGBUILD.diff (1.7 KiB)
Comment by strings (strings) - Saturday, 07 May 2011, 12:10 GMT
this should fix the godoc issue. its not perfect but its better then having a broken godoc.
   PKGBUILD (2.1 KiB)
   PKGBUILD.diff (0.5 KiB)
Comment by Vesa Kaihlavirta (vegai) - Thursday, 12 May 2011, 06:49 GMT
strings: your patch removes copying of the doc tree:

- cp -r doc misc -t $pkgdir/usr/share/go
+ cp -r lib misc src -t $pkgdir/usr/lib/go

Is that an oversight or don't we really need it?
Comment by strings (strings) - Thursday, 12 May 2011, 09:30 GMT
[edit] ignore this patch see comments below

Hello Vesa,

no that was not intended, this breaks serving of the html content. ie godoc -http=:6060

I've created another patch that fixes that, and also simplifies the PKGBUILD we do not need to install the Makefile templates.
since we copy the whole src tree to allow. # godoc os fmt

I've attached to fixes thanks for pointing this out.
   PKGBUILD (1.8 KiB)
   PKGBUILD.diff (0.8 KiB)
Comment by strings (strings) - Thursday, 12 May 2011, 09:34 GMT
there might be another issue with left over object files in the src tree. I'm looking at that now.

Also I know this is not very FHS friendly. we may want to ultimately symlink /usr/lib/go/doc to /usr/share/go. but as it stands in order for godoc to work from there it requires some patching which to me is not worth it. since it does not really use man pages and the likes.
Comment by strings (strings) - Thursday, 12 May 2011, 10:51 GMT
Vesa here is a revised patch, this cleans up the creation of folders in pkgdir which are not need now that we copy them directly.

It also removes unwanted object files from the src directory.

I've tested gc cgo and godoc, seems to be working well
   PKGBUILD (1.9 KiB)
   PKGBUILD.diff (1.1 KiB)
Comment by Vesa Kaihlavirta (vegai) - Monday, 30 May 2011, 12:28 GMT
Fixed in 57.1-3

Loading...