FS#19668 - [pkgtools] new pkgfile-cron-disabling mechanism doesn't work as advertised

Attached to Project: Community Packages
Opened by Isaac Dupree (idupree) - Tuesday, 01 June 2010, 03:25 GMT
Last edited by Gavin Bisesi (Daenyth) - Tuesday, 01 June 2010, 12:20 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Gavin Bisesi (Daenyth)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

/etc/pkgtools/pkgfile.conf says,
# UPDATE_CRON controls whether the cronjob that runs pkgfile --update
# will run. Setting it to 1 enables updates, setting to 0 disables

It's wrong about setting to zero, because /etc/cron.daily/pkgfile starts
#!/bin/bash
. /etc/pkgtools/pkgfile.conf
if [[ $UPDATE_CRON ]]; then

and in bash, [[ $variable ]] is true as long as variable has any contents at all; in other words, the way to disable the cron job in pkgfile.conf is:
UPDATE_CRON=
.

One of the two should be fixed, probably the bash code in the cron-script.
This task depends upon

Closed by  Gavin Bisesi (Daenyth)
Tuesday, 01 June 2010, 12:20 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#19609 
Comment by Isaac Dupree (idupree) - Tuesday, 01 June 2010, 03:29 GMT
e.g.

if [[ $UPDATE_CRON == 1 ]]; then

Loading...