AUR web interface

Tasklist

FS#19482 - Uploading fails when source=() array is redefined using array.

Attached to Project: AUR web interface
Opened by Masato Hashimoto (hashimo) - Sunday, 16 May 2010, 14:49 GMT
Last edited by Lukas Fleischer (lfleischer) - Monday, 21 February 2011, 09:51 GMT
Task Type Bug Report
Category PKGBUILD Parser
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version 1.6.0
Due in Version 1.8.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Please see attached PKGBUILD.

This PKGBUILD works properly but AUR doesn't accept .src.tar.gz include it; the uploading don't complete and blank page appear.

The cause of this problem is the following line:

> source=(${source[@]} "http://foo.bar.com/${_test[3]}.7z")

If source=() array is redefined and additional url use array variable, this problem occurs.
   PKGBUILD (0.9 KiB)
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Monday, 21 February 2011, 09:51 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.8.0.
Comment by Loui Chang (louipc) - Friday, 04 June 2010, 23:17 GMT
This PKGBUILD doesn't seem to work properly for me...
Your md5sums are wrong to start off with.
Comment by Masato Hashimoto (hashimo) - Saturday, 05 June 2010, 08:04 GMT
@Loui:

Sorry, please ignore urls in source=() array. foo.bar.com is dummy and no meaning (I didn't know foo.bar.com is exist).
Attached is test set for this issue.
Comment by Masato Hashimoto (hashimo) - Saturday, 05 June 2010, 08:04 GMT
Oops, attached here.
(application/x-gzip)    aur-issue-test-999-1.src.tar.... (0.6 KiB)
Comment by Loui Chang (louipc) - Saturday, 05 June 2010, 11:47 GMT
Alright thanks. :D
Though I don't plan on touching the parser, it's good to know where there are problems.
Comment by Lukas Fleischer (lfleischer) - Tuesday, 12 October 2010, 12:13 GMT
Yep, this is a problem of the PKGBUILD parser which fails to parse simple variable substituions if there are assigments of the form "foo=${foo}bar" or "bar=(${bar[@]} foobar)". Trying to replace such constructs, it ends up in an infinite loop (just check the "Simple variable replacement" part of the AUR). To fix this properly we'd need to rewrite huge parts of the parser tho...
Comment by Lukas Fleischer (lfleischer) - Wednesday, 02 February 2011, 15:52 GMT
Fixed in the master branch [1].

[1] http://projects.archlinux.org/aur.git/commit/?id=492c8c668f1edb708e49bcafbacb22c58e2877a5

Loading...