FS#19142 - [moc] freezes/locks-up

Attached to Project: Arch Linux
Opened by orbisvicis (orbisvicis) - Saturday, 17 April 2010, 22:33 GMT
Last edited by Eric Belanger (Snowman) - Friday, 10 June 2011, 23:03 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

problem: mocp freezes/locks-up, probably because of unusually long pathnames or badly-encoded utf8 chars or badly-encoded tags
summary: "*** glibc detected *** mocp: double free or corruption (!prev): 0x08bc9bf8 ***"

distribution:
Archlinux
$ uname -a
Linux cinnabar 2.6.33-ARCH #1 SMP PREEMPT Mon Apr 5 05:57:38 UTC 2010 i686 Genuine Intel(R) CPU T2400 @ 1.83GHz GenuineIntel GNU/Linux

mocp version:
$ mocp -V
moc 2.5.0-alpha4 Build: Feb 26 2010 04:32:50
Compiled with: OSS ALSA JACK DEBUG internet streams resample


$ mocp -DDDDD
in the ncurses display: press enter to play a selected file with an unusually long name, possibly badly-encoded utf8 chars, or possibly badly-encoded ogg tags
in the ncurses display: "*** glibc detected *** mocp: double free or corruption (!prev): 0x08bc9bf8 ***"
after control-z (stop), in the terminal
$ mocp -DDDDD
Loading plugins from /usr/lib/moc/decoder_plugins...
Loading plugin libffmpeg_decoder...
OK
Loading plugin libflac_decoder...
OK
Loading plugin libmodplug_decoder...
OK
Loading plugin libmp3_decoder...
OK
Loading plugin libmusepack_decoder...
OK
Loading plugin libsndfile_formats_decoder...
OK
Loading plugin libspeex_decoder...
OK
Loading plugin libvorbis_decoder...
OK
Loading plugin libwavpack_decoder...
OK
Running the server...
Trying JACK...
Trying ALSA...

[1]+ Stopped mocp -DDDDD
$ killall -s 9 mocp

$ strace -o mocp.one.strace mocp
File is attached
$ strace -o mocp.two.strace -f mocp
File is attached

Directory Information
$ ls -lah ~/mounts/sftp/Wolfgang\ Amadeus\ Mozart/
total 20K
drwxr-xr-x 1 ... 4.0K Apr 26 2009 .
drwxr-xr-x 1 ... 8.0K Mar 8 16:55 ..
drwxr-xr-x 1 ... 4.0K Dec 27 2008 Piano Concerti Nos. 12 and 14 (I Musici de Montréal feat. conductor: Yuli Turovsky, piano: Louis Lortie)
drwxr-xr-x 1 ... 4.0K Apr 26 2009 String Quintets K. 516, 593 (Pražák Quartet with Hatto Beyerlé)
$ ls -lah ~/mounts/sftp/Wolfgang\ Amadeus\ Mozart/Piano\ Concerti\ Nos.\ 12\ and\ 14\ \(I\ Musici\ de\ Montréal\ feat.\ conductor\:\ Yuli\ Turovsky\,\ piano\:\ Louis\ Lortie\)/
total 50M
drwxr-xr-x 1 ... 4.0K Dec 27 2008 .
drwxr-xr-x 1 ... 4.0K Apr 26 2009 ..
-rw-r--r-- 1 ... 11M Dec 27 2008 01 - Concerto for Piano No. 12 in A major, K. 385p-414: I. Allegro.ogg
-rw-r--r-- 1 ... 8.8M Dec 27 2008 02 - Concerto for Piano No. 12 in A major, K. 385p-414: II. Andante.ogg
-rw-r--r-- 1 ... 6.6M Dec 27 2008 03 - Concerto for Piano No. 12 in A major, K. 385p-414: III. Rondo. Allegretto.ogg
-rw-r--r-- 1 ... 9.4M Dec 27 2008 04 - Concerto for Piano No. 14 in E-flat major, K. 449 "First Ployer": I. Allegro vivace.ogg
-rw-r--r-- 1 ... 7.7M Dec 27 2008 05 - Concerto for Piano No. 14 in E-flat major, K. 449 "First Ployer": II. Andantino.ogg
-rw-r--r-- 1 ... 6.3M Dec 27 2008 06 - Concerto for Piano No. 14 in E-flat major, K. 449 "First Ployer": III. Allegro ma non troppo.ogg

The file that causes the crash
$ ogginfo 01\ -\ Concerto\ for\ Piano\ No.\ 12\ in\ A\ major\,\ K.\ 385p-414\:\ I.\ Allegro.ogg
Processing file "01 - Concerto for Piano No. 12 in A major, K. 385p-414: I. Allegro.ogg"...

New logical stream (#1, serial: 78b5ac15): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Xiph.Org libVorbis I 20070622 (1.2.0)
Channels: 2
Rate: 44100

Nominal bitrate: 160.000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
TITLE=Concerto for Piano No. 12 in A major, K. 385p/414: I. Allegro
ARTIST=Wolfgang Amadeus Mozart
TRACKNUMBER=1
TRACKTOTAL=6
ALBUM=Piano Concerti Nos. 12 and 14 (I Musici de Montréal feat. conductor: Yuli Turovsky, piano: Louis Lortie)
MUSICBRAINZ_ALBUMID=c1fae8d1-f268-42ca-b651-12bd98812405
MUSICBRAINZ_ALBUMARTISTID=b972f589-fb0e-474e-b64a-803b0364fa75
MUSICBRAINZ_ARTISTID=b972f589-fb0e-474e-b64a-803b0364fa75
MUSICBRAINZ_TRACKID=e82f0945-c825-4b9f-a99a-4e7481dc227c
ARTISTSORT=Mozart, Wolfgang Amadeus
DATE=1987-01-01
DISCID=4e0b5606
MUSICBRAINZ_DISCID=5McMhdgVF905FYRM1QZkcM1g448-
Vorbis stream 1:
Total data length: 11396136 bytes
Playback length: 10m:36.453s
Average bitrate: 143.245519 kb/s
Logical stream 1 ended

$ mocp -DDDDDDDDDDDDDDDD
mocp_client_log is attached
mocp_server_log is attached

$ gdb
attach client_process
attach server_process
cont
...
no interesting output

$ valgrind --trace-children=yes --log-file=mocp.valgrind.one mocp
in the ncurses display: play the file
. mocp under valgrind does not lock-up
in the ncurses display: quit
in the terminal: mocp -x
valgrind output is attached


summary of attached files
mocp_client_log client debugging output
mocp_server_log server debugging output
mocp.one.strace strace output
mocp.two.strace strace forked child processes
mopc.valgrind.one valgrind output

I can also email the ogg file causing the problems

This issue seems somewhat similar to the unresolved and now closed debian bug at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=547678
This task depends upon

Closed by  Eric Belanger (Snowman)
Friday, 10 June 2011, 23:03 GMT
Reason for closing:  Fixed
Additional comments about closing:  moc 20110528-2
Comment by orbisvicis (orbisvicis) - Saturday, 17 April 2010, 22:39 GMT
mocp.one.strace: strace output
mocp.two.strace: strace forked child processes
mocp.valgrind.one: valgrind output
mocp_client_log: client debugging output
mocp_server_log: server debugging output
report: a text copy of the bug report preserving formatting

@arch - I reported this upstream bug here in order to upload files. The upstream report is at http://moc.daper.net/node/631
Comment by Dan Griffiths (Ghost1227) - Sunday, 18 April 2010, 07:40 GMT
Keep me informed of any upstream progress
Comment by Heiko Baums (cyberpatrol) - Sunday, 09 May 2010, 22:07 GMT
I've got the same problem, which is really annoying, because I sometimes listen to classical music where this issue usually appears. So I can't listen to my classical music files with moc, my favorite audio player. After downgrading moc by abs to the latest stable release 2.4.4 it's working correctly again.

So it would be nice if you would downgrade moc to 2.4.4 in [extra] until this bug is fixed by upstream. moc 2.5.0-alpha4 is an alpha version, which is marked as unstable, anyway. And I don't think that unstable versions should be in the official repos particularly if they are so buggy. And I don't see any significant changes in 2.5.0-alpha4.

Btw, this bug doesn't seem to be related to long file names but long tags.

Here's the upstream bug report: http://moc.daper.net/node/631
Comment by Eric Belanger (Snowman) - Sunday, 29 May 2011, 06:24 GMT
Could you test the package there: https://dev.archlinux.org/~eric/moc/ and let me know if the problem is fixed? I would like to update moc to a svn snapshot to fix  FS#22971 . I think that there was a related fix in svn but I can't reproduce this bug even with the 2.5.0-alpha4 tarball.

Comment by Heiko Baums (cyberpatrol) - Sunday, 29 May 2011, 13:01 GMT
I have no issues with this package on x86_64. Every issue I know of seems to be fixed.
So moc upstream seems not to be entirely dead. :-)
Comment by Eric Belanger (Snowman) - Monday, 30 May 2011, 21:05 GMT
Thanks but it didn't fixed the problem in the other bug report. I've put moc-20110528-1 in testing. It uses the most recent svn snapshot.
Comment by Heiko Baums (cyberpatrol) - Monday, 30 May 2011, 21:41 GMT
Which other bug do you mean?

These bugs are fixed with your package:
http://moc.daper.net/node/631
 FS#23879 
 FS#23193 

If you mean  FS#22971 , I can't say anything about it as I'm not using OSS.
Comment by Eric Belanger (Snowman) - Tuesday, 31 May 2011, 01:03 GMT
I was talking about  FS#22971 .

Loading...