FS#18422 - [iptables] Wrong sed -ie in iptables' PKGBUILD

Attached to Project: Arch Linux
Opened by Leonid Isaev (lisaev) - Sunday, 21 February 2010, 20:46 GMT
Last edited by Ronald van Haren (pressh) - Wednesday, 24 February 2010, 11:48 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Ronald van Haren (pressh)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

As it was pointed out in a forum discussion, there is a potential bug in the iptables PKGBUILD.
Namely (possibly there are other sed calls like this),

sed -ie '87 i libxt_RATEEST.so: libxt_RATEEST.oo' extensions/GNUmakefile.in
sed -ie '88 i \\t${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -lm -shared ${LDFLAGS} -o $@ $<;\n' extensions/GNUmakefile.in

should be

sed -i -e '87 i libxt_RATEEST.so: libxt_RATEEST.oo' extensions/GNUmakefile.in
sed -i -e '88 i \\t${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -lm -shared ${LDFLAGS} -o $@ $<;\n' extensions/GNUmakefile.in

because 'e' is not considered as an 'execute' directive. This is harmless, since it would work even without '-e'.

Please see the related bug report against qt3 package:  FS#18371 

Thank you

Additional info:
* package version(s)

iptables 1.4.6-1

* config and/or log files etc.
Steps to reproduce:
This task depends upon

Closed by  Ronald van Haren (pressh)
Wednesday, 24 February 2010, 11:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in trunk

Loading...