Arch Linux

Summary and Info:
------------------------

There's a bug in the function create_srcpackage() in the makepkg script. It first adds the install file to the sourcepackage-dir and after that all files in the source array (expect the url-ones..).

line 1056ff.:
if [ -n "$install" ]; then
if [ -f $install ]; then
msg2 "$(gettext "Adding install script...")"
ln -s "${startdir}/$install" "${srclinks}/${pkgbase}/"
else
error "$(gettext "Install script %s not found.")" "$install"
fi
fi

[...]

local netfile
for netfile in "${source[@]}"; do
local file=$(get_filename "$netfile")
if [ -f "$netfile" ]; then
msg2 "$(gettext "Adding %s...")" "$netfile"
ln -s "${startdir}/$netfile" "${srclinks}/${pkgbase}"
elif [ "$SOURCEONLY" -eq 2 -a -f "$SRCDEST/$file" ]; then
msg2 "$(gettext "Adding %s...")" "$file"
ln -s "$SRCDEST/$file" "${srclinks}/${pkgbase}/"
fi
done


The problem now is that if we add the .install file to the source-array because we want to have it md5sum checked like every other file, the function tries to link to it a second time with all the other sourcefiles and fails because the symlink has already created before. This results in makepkg aborting.


Steps to Reproduce:
------------------------

Create a PKGBUILD which has an install file and specify it in the source array too:
[..]
install=test.install
source=(test.install)
[..]
and try to create a source-package with makepkg --source.


Fix:
------------------------
If we have already successfully created the symlink for the install file it's safe to remove it from the source-array before the source-array is used to symlink all the other files. Patch is attached.