Arch Linux

Please read this before reporting a bug:

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!

FS#17910 - [imlib2] mistake in libpng1.4 patch

Attached to Project: Arch Linux
Opened by xduugu (xduugu) - Wednesday, 20 January 2010, 00:58 GMT
Last edited by Eric Belanger (Snowman) - Wednesday, 20 January 2010, 03:50 GMT
Task Type Bug Report
Category Packages: Testing
Status Closed
Assigned To No-one
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


From libpng-1.4.0.txt:
> The function
> png_check_sig(sig, num)
> was replaced with
> !png_sig_cmp(sig, 0, num)
> It has been deprecated since libpng-0.90.

Thus, the patch should look like

- if (!png_check_sig(buf, PNG_BYTES_TO_CHECK))
+ if (png_sig_cmp(buf, 0, PNG_BYTES_TO_CHECK))

(= remove the exclamation mark in front of png_sig_cmp in the current patch)

The current imlib2 packages breaks awesome whereas a correctly patched one works.

Additional info:
* 1.4.2-5
This task depends upon

Closed by  Eric Belanger (Snowman)
Wednesday, 20 January 2010, 03:50 GMT
Reason for closing:  Fixed