AUR web interface

Tasklist

FS#17584 - Out-of-date notification emails have two To: fields (one of which is empty)

Attached to Project: AUR web interface
Opened by Gaetan Bisson (vesath) - Wednesday, 23 December 2009, 00:07 GMT
Last edited by Andrea Scarpino (BaSh) - Saturday, 29 May 2010, 18:10 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 1.6.0
Due in Version 1.7.0
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

The out-of-date notification emails sent by AUR bear two To: fields, one of which is empty.
For instance, below is an excerpt from one such email I received recently.

Received: by sigurd.archlinux.org (Postfix, from userid 33)
id 35E002DA66A; Tue, 22 Dec 2009 18:20:50 -0500 (EST)
To:
Subject: AUR Out-of-date Notification for collectd
To: gaetan.bisson@loria.fr
Reply-to: nobody@archlinux.org
From: aur-notify@archlinux.org
X-Mailer: PHP
X-MimeOLE: Produced By AUR
Message-Id: <20091222232050.35E002DA66A@sigurd.archlinux.org>
Date: Tue, 22 Dec 2009 18:20:50 -0500 (EST)
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Saturday, 29 May 2010, 18:10 GMT
Reason for closing:  Fixed
Additional comments about closing:  http://projects.archlinux.org/aur.git/co mmit/?id=74f22eeb2a79daeec7d765dda1befd1 a6baa1554
Comment by Lukas Fleischer (lfleischer) - Saturday, 29 May 2010, 15:15 GMT
I can confirm/reproduce this bug. "To:" headers are included twice because PHP's internal mail() function is used and both $to and $additional_headers including a "To: " header are specified (see pkg_flag() function in "web/lib/pkgfuncs.inc"). This is actually *really* annoying since I don't receive any notification mails anymore after upgrading my mail server to OpenBSD 4.7 (might be due to spamd(8) and/or OpenSMTPd rejecting duplicate "To:" headers after the last upgrade, didn't analyse that in detail).

This can easily be fixed by removing "To: " field from additional headers and specifying the correct recipient address in the mail() call. Patch attached.

[edit]Just noticed that this has already been fixed in the GIT repo [1].[/edit]

[1] http://projects.archlinux.org/aur.git/diff/?id=74f22eeb2a79daeec7d765dda1befd1a6baa1554
   pkg_flag-fix-To-headers.patch (0.9 KiB)

Loading...