AUR web interface

Tasklist

FS#17197 - Submit: Unknown file format for uploaded file.

Attached to Project: AUR web interface
Opened by Gergely (imrehg) - Thursday, 19 November 2009, 01:10 GMT
Last edited by Loui Chang (louipc) - Sunday, 22 November 2009, 08:35 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To No-one
Architecture All
Severity High
Priority Normal
Reported Version 1.6.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Package submission fails if trying to upload PKGBUILD, .src.tar.gz of the same things works fine.

1) Expected:
Normal package submission, no error on properly formed PKGBUILDS

2) What I get:
For a while now, whenever I try to upload a PKGBUILD to AUR, I get the following error message on an almost completely empty screen:

Submit
Unknown file format for uploaded file.

This is for any new and also for any already successfully submitted packages.
A workaround is preparing the package with makepkg --source, and submitting the .src.tar.gz, which works as intended.

Not sure if relevant:
Browser: Firefox 3.5.5
This task depends upon

Closed by  Loui Chang (louipc)
Sunday, 22 November 2009, 08:35 GMT
Reason for closing:  Not a bug
Comment by Allan McRae (Allan) - Thursday, 19 November 2009, 01:18 GMT
I believe that is intended as "makepkg --source" does some sanity checking on the PKGBUILD before creating the tarball.
Comment by Gergely (imrehg) - Thursday, 19 November 2009, 02:38 GMT
But this happens to every PKGBUILD that I try - even when attempting to re-submit one that already worked before. The updates I do on those PKGBUILDs are trivial anyway (updating version numbers + md5sums), that should not break it.

Also: I don't think "makepkg --source" modifies the PKGBUILD, so it is the same on its own and in the tar.gz, so why the difference?
Comment by Allan McRae (Allan) - Thursday, 19 November 2009, 02:49 GMT
I never said that "makepkg --source" modifies the PKGBUILD. It just does some basic checking on it and if it find errors it will not make the tarball. The AUR developers appear to have decide all packages must go through this check.
Comment by Ionut Biru (wonder) - Thursday, 19 November 2009, 10:11 GMT
submitting single PKGBUILD is deprecated.
Comment by Gergely (imrehg) - Thursday, 19 November 2009, 13:37 GMT
Ah, then I just wasn't aware of the change. Cannot be very well advertised if "appear to have decided"....

To close this report, can there be (pertty please) a proper notice and announcement somewhere? And on the submit page, not call it "package file" because it's not self-explanatory, neither is the error message.... It would be better to spell it out that one needs to submit a "makepkg --source" prepared tar.gz
Comment by xduugu (xduugu) - Thursday, 19 November 2009, 16:34 GMT
See [1] but as far as I know this feature[2] was never documented anywhere.

[1] http://projects.archlinux.org/aur.git/commit/?id=6ee8b88c58c984489e13eb26f8509fe1ddb1510a
[2] http://projects.archlinux.org/aur.git/commit/?id=4ac945a87e5c7e71831377bc95563aa53e7f1eaa
Comment by Gergely (imrehg) - Thursday, 19 November 2009, 17:24 GMT
[2] Curiously I did know that I can submit .tar.gz (not sure where from), but it's new to me that it is the only way. [2] is a commit very long time ago, it is not like that anymore (see [A])...

[1] Yeah, more like it. That has some instruction, even if it's still in the "cooker", meaning not in the deployed version. It would be better, though, to remove more ambiguity (e.g. adding "Upload compressed package file").
My reasoning for me would be, that everywhere else PKGBUILD feels the "unit" of a package, so many of them can be done in a single file, and abs & yaourt will get you the PKGBUILD not an .src.tar.gz, thus requiring that for an upload even for a single file feels unnatural. I see the reason, and hack, I can even endorse it, but everything that is out of the "usual ways" should be noted a bit (lot) more. Then you wouldn't have such shallow bug reports as this one. :P

[A] http://projects.archlinux.org/aur.git/tree/web/html/pkgsubmit.php?id=6ee8b88c58c984489e13eb26f8509fe1ddb1510a#n39

Loading...