Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#17020 - [gtk2] a lot of "Gdk-WARNING **: XID collision, trouble ahead" messages

Attached to Project: Arch Linux
Opened by Baeyens (berbae) - Thursday, 05 November 2009, 15:56 GMT
Last edited by Jan de Groot (JGC) - Sunday, 08 November 2009, 21:13 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Within about 6 hours using Firefox, I got 21374 messages of "XID collision" dumping the log files.

This problem is not new with gtk2 2.18 and it is an upstream problem :
see http://bbs.archlinux.org/viewtopic.php?id=76527

But as this annoying message is there only for debugging purpose, and it was not suppressed yet with this new gtk2 release, I suggest to patch the source to prevent this warning to appear and to dump the log files with useless warnings.
I propose this patch gdkxid.patch :

--- gtk+-2.18.3/gdk/x11/gdkxid.c 2009-06-19 04:59:18.000000000 +0200
+++ gtk+-2.18.3/gdk/x11/gdkxid.c.new 2009-07-22 11:30:12.000000000 +0200
@@ -56,10 +56,10 @@
if (!display_x11->xid_ht)
display_x11->xid_ht = g_hash_table_new ((GHashFunc) gdk_xid_hash,
(GEqualFunc) gdk_xid_equal);
-
+/*
if (g_hash_table_lookup (display_x11->xid_ht, xid))
g_warning ("XID collision, trouble ahead");
-
+*/
g_hash_table_insert (display_x11->xid_ht, xid, data);
}

and the modified PKGBUILD attached.

I rebuild the gtk2 package personnally with the patch, but it would be nice that others benefit also.

   PKGBUILD (1.5 KiB)
   gdkxid.patch (0.5 KiB)
This task depends upon

Closed by  Jan de Groot (JGC)
Sunday, 08 November 2009, 21:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  2.18.3-2.
Comment by Jan de Groot (JGC) - Thursday, 05 November 2009, 18:02 GMT
Nice way to fix a bug, just remove the way it notices you.
Comment by Baeyens (berbae) - Friday, 06 November 2009, 17:29 GMT
From the man who added this test, it's a debugging message for application developpers, which I am not.
And using only Firefox, the XID collision messages flood log files, and this is useless for me.
It would be better to have that test enabled as a debugging option for developpers.
Haven't you noticed the big number of these messages just using Firefox ?

Comment by Jan de Groot (JGC) - Friday, 06 November 2009, 20:13 GMT
I think about changing g_warning to g_debug. That way it only shows up when you run things in debug mode.
Comment by Baeyens (berbae) - Friday, 06 November 2009, 22:36 GMT
I didn't know about that possibility, but it seems a good way to keep the test in the source code, without the non developper user to see the warnings all the time.
It would be nice like that.
Thank you very much for considering that change.
Comment by Jan de Groot (JGC) - Sunday, 08 November 2009, 21:12 GMT
Hmm, setting this to g_debug will not disable the warning, it will just generate debug messages.
Somehow this warning message is triggered in a loop as soon as you enter a website with flash content. i'll disable the warning for now, as it's annoying to see your console or logs filled with a debug warning.

Loading...