Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#16919 - [initscripts] rc.shutdown try to remove crypted partition already gone

Attached to Project: Arch Linux
Opened by solsTiCe (zebul666) - Friday, 30 October 2009, 10:17 GMT
Last edited by Roman Kyrylych (Romashka) - Saturday, 05 December 2009, 14:52 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
if i manually remove a mapping done with cryptsetup (at boot time by /etc/crypttab), rc.shutdown try anyway to remove that non-existent mapping

for example sda2 mappings created at boot time.
then there is a /dev/mapper/sda2.
$ cryptsetup luksClose sda2
/dev/mapper/sda2 is gone
but rc.shutdown try to remove it anyway, causing an error

proposed patch is just to check if mapping is still there before trying to remove it with a test
if [ -b /dev/mapper/$1 ]

alternate test could be
if cryptsetup status $1 &>/dev/null

cons:
- the error is harmfull except it pollutes the shutdown screen
- it is not THE normal way of things to manually remove a crypted partition automatically mounted

pros:
- it's just a simple test
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Saturday, 05 December 2009, 14:52 GMT
Reason for closing:  Fixed
Additional comments about closing:  in git
Comment by solsTiCe (zebul666) - Friday, 30 October 2009, 10:19 GMT
oops i mean harmless not harmfull. i.e there is just a 'failed' printed on screen. that's all but it has no reason to be there
Comment by Laszlo Papp (djszapi) - Saturday, 07 November 2009, 06:03 GMT
maybe it's better to post git formatted patch next time.
Comment by Thomas Bächler (brain0) - Saturday, 07 November 2009, 11:55 GMT
Seems good, just forgot to apply it.

Loading...