FS#16610 - [xmms2] xmms2.install file too verbose, even superfluous

Attached to Project: Community Packages
Opened by quantax (quantax) - Tuesday, 13 October 2009, 10:04 GMT
Last edited by Sergej Pupykin (sergej) - Wednesday, 14 October 2009, 07:05 GMT
Task Type Bug Report
Category
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

The install file of xmms2-0.6DrMattDestruction-8 is unnecessarily verbose, even superfluous.

> pre_install() {
> echo "-- DO NOT FORGET edit /etc/conf.d/xmms2.conf!"
> /bin/true
> }

You don't have to edit it if you are running xmms2 as a user. This is much more convenient as the client automatically starts and stops the daemon. Even if you run the daemon as a separate user one usually knows where to look for the configuration of the rc script.

> post_install() {
> cat << EOF
> ==> NOT included depencies(with reasons):
> [...]
> Plugin installation:
> ----
> [...]

Since  FS#15575  all this -- now even outdated -- info is included in the optdepends array. Thus on package upgrade pacman prints it twice: once from the optdepends information and once from the install file. This is totally unnecessary.

In order not to clutter the pacman output with unnecessary output I suggest removing xmms2.install completely from the package. If a user needs more detailed info on the installation or the software the wiki is usually a better place for it.

I hope this does not sounds too harsh. I just want to keep the package clean. And thanks for taking care of xmms2. :)
This task depends upon

Closed by  Sergej Pupykin (sergej)
Wednesday, 14 October 2009, 07:05 GMT
Reason for closing:  Fixed

Loading...