FS#16378 - [nexuiz] jpeg bug

Attached to Project: Community Packages
Opened by cookie (ammon) - Sunday, 27 September 2009, 22:55 GMT
Last edited by Xyne (Xyne) - Monday, 28 September 2009, 21:41 GMT
Task Type Bug Report
Category
Status Closed
Assigned To Xyne (Xyne)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Nexuiz can't save screenshots. Game saves it in .jpg. But files are 0kb in size. What is strange is that it can read jpeg files. I've asked nexuiz devs, and they are sure that it is not a Nexuiz bug. But has something to do with system libjpeg.
This is the output:

JPEG parameter struct mismatch: library thinks size is 568, caller expects 528
Unable to write screenshots/nexuiz000001.jpg


Additional info:
* package version(s)

2.5.1-2

Steps to reproduce:

Install Nexuiz from community repo, start it. Press f12 to take screenshot. Then go to ~/.nexuiz/screenshots and see that file.
This task depends upon

Closed by  Xyne (Xyne)
Monday, 28 September 2009, 21:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  A patch has been applied and the upstream developers have been notified of the problem.
Comment by Gerardo Exequiel Pozzi (djgera) - Sunday, 27 September 2009, 23:30 GMT
  • Field changed: Summary (Nexuiz jpeg bug → [nexuiz] jpeg bug)
  • Field changed: Status (Unconfirmed → Waiting on Response)
  • Field changed: Category (Upstream Bugs → )
  • Field changed: Architecture (x86_64 → All)
  • Task assigned to Xyne (Xyne)
a link to bug in bugtracker?

There are some changes in libjpeg7 that make it incompatible with some apps.
Comment by Rick Chen (stuffcorpse) - Monday, 28 September 2009, 07:21 GMT
I've amended the patch I sent earlier (for the libjpeg7 switch)
and fixed taking screenshots. It is attached.

This is a Nexuiz bug because although it uses the system's libjpeg, it
does not use the headers provided. Instead a minimal version of the
header is included in Nexuiz's source which breaks things when the
system's jpeg libraries got updated.
   nexuiz-libjpeg-fix.patch (6.5 KiB)
Comment by cookie (ammon) - Monday, 28 September 2009, 09:24 GMT
Yes, that fixes it. Thanks.

I will report this to Nexuiz devs.
Comment by Xyne (Xyne) - Monday, 28 September 2009, 09:58 GMT
I'll look into this tonight (no time right now). If I have to update the package I want to take the opportunity to split it into "nexuiz" and "nexuiz-data" because the data is architecture-independent.
Comment by cookie (ammon) - Monday, 28 September 2009, 10:07 GMT
Good idea Xyne. :)
Comment by Rick Chen (stuffcorpse) - Monday, 28 September 2009, 10:13 GMT
Thanks Xyne, much appreciated.
Comment by Xyne (Xyne) - Monday, 28 September 2009, 21:39 GMT
Ok, I've just finished uploading the package(s) with the following changes:
* split package: nexuiz -> nexuiz + nexuiz-data
* applied Rick Chen's patch (works here) and added him to the list of contributors (thanks)

Future patches should only require a ~2.5 MB download (and upload) :)

Loading...