In /etc/rc.d/functions, printf fails when called with an argument starting with a dash, causing the script using the function to crash.

I found this when calling /etc/rc.d/net-auto from pm-suspend sleep.d, it happens when netcfg-auto-wireless calls stat_append(). As there is no attached terminal, $C_MAIN is not set, therfore printf is called with $1 as the first arg which is "- No networks available." in this case.

/etc/rc.d/functions:

stat_append() {
printf "${RESTORE_POSITION}"
printf "${C_MAIN}${1}${C_CLEAR}"
printf "${SAVE_POSITION}"
}

/usr/bin/netcfg-auto-wireless:

if [[ ! "$networks" ]]; then
stat_append "- No networks available."
stat_fail
exit 1
fi

This cases the following error:

/etc/rc.d/functions: line 99: printf: - : invalid option
printf: usage: printf [-v var] format [arguments]
[FAIL]


Possible solution for functions:

call printf with -- before the argument.

Workaround - put the following in functions.d:

stat_append() {
printf "${RESTORE_POSITION}"
printf -- "${C_MAIN}${1}${C_CLEAR}"
printf "${SAVE_POSITION}"
}


I raised this here as other scripts may run into the same issue, this may also affect other functions.


Name : initscripts
Version : 2009.03-2

Name : netcfg
Version : 2.2.1-1

Name : bash
Version : 4.0.024-1

x86_64

Steps to reproduce:

I've modified the the standard 11netcfg pm-utils script copied from /usr/lib/pm-utils/sleep.d/11netcfg:

resume_netcfg() {
netcfg2 all-resume &> /dev/null
if [ ! -e /var/run/interfaces/wlan0 ]; then
echo "No wireless"
/etc/rc.d/net-auto restart &> /tmp/wireless
else
echo "Wireless network already up"
fi
}

Turn of the radio so the network connect with fail (rfkill), then resume from sleep.