FS#15707 - [filesystem] New grpck barks on gshadow

Attached to Project: Arch Linux
Opened by Gerhard Brauer (GerBra) - Tuesday, 28 July 2009, 08:57 GMT
Last edited by Allan McRae (Allan) - Sunday, 01 November 2009, 04:04 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
After shadow update 4.1.3.1-1 -> 4.1.4.1-1 grpck complained about group entries in /etc/gshadow which don't have a disbaled password field in /etc/group.
Like:
"group sys has an entry in /etc/gshadow, but its password field in /etc/group is not set to 'x'"

Testing with grpck from 4.1.3.1-1 don't complain about that, so it's new in current version.

Additional info:
* package version(s)
shadow 4.1.4.1-1
initscripts 2009.03-2
(AFAIK new initscripts from testing would have the same problem)

Maybe we should fix the password field in /etc/group.
Groups added by affected tools produces correct entries in group/gshadow.

Steps to reproduce:

Run grpck
This task depends upon

Closed by  Allan McRae (Allan)
Sunday, 01 November 2009, 04:04 GMT
Reason for closing:  Fixed
Additional comments about closing:  filesystem-2009.11
Comment by Gerardo Exequiel Pozzi (djgera) - Tuesday, 28 July 2009, 09:15 GMT
I guess that you intent to said "filesystem" instead of "initscripts". true?
Comment by Gerhard Brauer (GerBra) - Tuesday, 28 July 2009, 09:22 GMT
Yes! ;-) sorry, lack of coffee...
Comment by Thomas Bächler (brain0) - Tuesday, 28 July 2009, 09:42 GMT
Shouldn't grpck correct those errors? It doesn't do that here.
Comment by Gerhard Brauer (GerBra) - Tuesday, 28 July 2009, 09:51 GMT
No, AFAIK grpck correct only syntax errors, not "logical" mistakes. IMHO this should be changed in filesystem->/etc/group
for the initial groups. And in those packages which may not use groupadd to add a system group...
Comment by Gerhard Brauer (GerBra) - Tuesday, 28 July 2009, 10:09 GMT
Also there is no tool to correct this later (neither groupmod nor gpasswd could do that).
Need to be corrected in $EDITOR or via sed...
Comment by Roman Kyrylych (Romashka) - Tuesday, 28 July 2009, 11:11 GMT
So, the solution is easy: fix /etc/group in the next package version.
No special handling needs to be done, users should merge changes from .pacnew with their /etc/group
If it is believed that grpck should correct such errors - I think this can be reported as a feature request to upstream.
Comment by Aaron Griffin (phrakture) - Tuesday, 28 July 2009, 17:36 GMT
Committed a changed /etc/group to filesystem trunk

Loading...