FS#15600 - [git] does not depend on openssh

Attached to Project: Arch Linux
Opened by Thought Crime (thoughtcrime) - Monday, 20 July 2009, 13:01 GMT
Last edited by Dan McGee (toofishes) - Tuesday, 15 September 2009, 00:53 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
I've tried to do a git push somewhere and it returned:
GIT Error: fatal: The remote end hung up unexpectedly

After I installed openssh, the error didn't appear anymore. I suggest making openssh a dependency of git.
This task depends upon

Closed by  Dan McGee (toofishes)
Tuesday, 15 September 2009, 00:53 GMT
Reason for closing:  Won't fix
Additional comments about closing:  A bit silly to me
Comment by Allan McRae (Allan) - Monday, 20 July 2009, 13:09 GMT
I'm slightly confused by the description... wouldn't you need to check out the repo over ssh in the first place.

Anyway, probably is an optdepend.
Comment by Thought Crime (thoughtcrime) - Monday, 20 July 2009, 13:14 GMT
I've actually reinstalled my system, then did some change to some files and tried to push it afterwards.
Nope, it is not an optional dependency:

<WillySilly> Jesus died and rose from the dead in 3 days. It took Jack Bauer less than an hour. And he's done it twice.

thoughtcrime ~ $ yaourt -S git
Passwort:
BOB says: You seem to have forgotten your passwd, enter another!
Passwort:
Warnung: git-1.6.3.3-1 ist aktuell -- Reinstalliere
Löse Abhängigkeiten auf...
Suche nach Zwischen-Konflikten...

Pakete (1): git-1.6.3.3-1

Gesamtgröße der heruntergeladenen Pakete: 0,00 MB
Gesamtgröße der installierten Pakete: 14,54 MB

Installation fortsetzen? [J/n] J
Prüfe Paketintegrität...
(1/1) Prüfe auf Dateikonflikte [#####################] 100%
(1/1) Aktualisiere git [#####################] 100%
Optionale Abhängigkeiten für git
tk: gitk and git gui
perl-libwww: git svn
perl-term-readkey: git svn
subversion: git svn
cvsps: git cvsimport
thoughtcrime ~ $
Comment by xduugu (xduugu) - Monday, 20 July 2009, 13:36 GMT
From git's INSTALL file: http://git.kernel.org/?p=git/git.git;a=blob;f=INSTALL;h=ae7f7508f8e8cffeb930c820e068ba70dabff7bd;hb=maint
- Git is reasonably self-sufficient, but does depend on a few external
programs and libraries:

- "zlib", the compression library. Git won't build without it.

- "openssl". Unless you specify otherwise, you'll get the SHA1
library from here.

If you don't have openssl, you can use one of the SHA1 libraries
that come with git (git includes the one from Mozilla, and has
its own PowerPC and ARM optimized ones too - see the Makefile).



But I wonder why you do not have openssl installed anyway since libarchive (and therefore pacman) depends on it.
Comment by xduugu (xduugu) - Monday, 20 July 2009, 13:45 GMT
I apologize for my off-topic post. Did not noticed that this is about openssH and not openssL...

To be at least a little bit constructive, here is another quote from the already mentioned INSTALL file:
- Git is reasonably self-sufficient, but does depend on a few external
programs and libraries:

[...]

- "ssh" is used to push and pull over the net
Comment by Dan McGee (toofishes) - Monday, 20 July 2009, 14:53 GMT
WTF? Is this bug about OpenSSH or OpenSSL? The comments are all over the place here, and I don't even see what the problem is.

The original report doesn't tell me *why* this should be listed as an optdepend at best, and why installing it fixed whatever problem you were facing.
Comment by Thought Crime (thoughtcrime) - Monday, 20 July 2009, 14:56 GMT
this is about openSS__H__. GIT itself depends ons SSH, as xduugu points out in his second post, so I suggested to add it as dependency (not optional, real one).
Comment by Dan McGee (toofishes) - Monday, 20 July 2009, 15:29 GMT
If you are not cloning or pulling or pushing over SSH, git has no dependency on SSH. Do we need to be so obvious as to add this? I assumed people were smart around here...
Comment by Thought Crime (thoughtcrime) - Monday, 20 July 2009, 15:35 GMT
Because the error message is very cryptic (as in "details" above), it would at least be useful as optional dependency. The error really confused me at first and after some googling, I came up with checking my ssh stuff and noticed, that openssh is not installed.
Comment by Dan McGee (toofishes) - Monday, 20 July 2009, 15:42 GMT
Perhaps it would be worth reporting this upstream as well? You failed to mention a lot of detail in the original report, so sorry this has descended into a lot of junk. Things like what type of repo you were pushing to, the command executed, etc...
Comment by Thought Crime (thoughtcrime) - Monday, 20 July 2009, 16:23 GMT
The actual command was:
git push git@gitorious.org:project/mainline.git master

Sorry for not posting this in the first place. Do you really think I should report this upstream?
Comment by Dan McGee (toofishes) - Monday, 20 July 2009, 16:39 GMT
Sounds like it. Given that you showed an implicit SSH URL there, this isn't too surprising and really has nothing to do with whether this is listed as an optdepend at all...
Comment by Thought Crime (thoughtcrime) - Monday, 20 July 2009, 16:48 GMT
I just think that it might be useful to list that as an optional dependency. Why not? It makes sense to me. You can optionally use openssh to do "git push"? And I'll try to report the bug upstream...

Loading...