FS#15308 - rpc and web interfaces use different logic to build the tarball url.

Attached to Project: AUR web interface
Opened by Randy Morris (rson451) - Monday, 29 June 2009, 00:33 GMT
Last edited by Lukas Fleischer (lfleischer) - Monday, 21 February 2011, 09:50 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Medium
Priority Normal
Reported Version 1.5.6.2
Due in Version 1.8.0
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

The aur rpc and web interfaces use different logic to build the tarball url, resulting in different results in certain instances. Examples of this can be seen with 'hdate-applet', 'hcal-gtk', and 'hocr'. The rpc interface returns a URLPath of /packages/$pkgname/PKGBUILD.tar.gz while the web interface shows a url of /packages/$pkgname/$pkgname.tar.gz.

The rpc interface retrieves the URLPath from a database, aurjson.class.php line 22.
The web builds the url from $pkgname, templates/pkg_details.php lines 61-62.

Suggested fix would be to use the value stored in the database (after all, why have it if you aren't going to use it?), however this will generate bugs on the aur webpage for every package that is incorrect in the database.
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Monday, 21 February 2011, 09:50 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.8.0.
Comment by Lukas Fleischer (lfleischer) - Monday, 24 January 2011, 17:15 GMT
Pushed a fix to my working tree [1]. Needs some more testing before I push this to the official repo tho.

[1] http://git.cryptocrack.de/aur.git/commit/?id=556de318aeeef6019bb7628389beee1358de93f8
Comment by Lukas Fleischer (lfleischer) - Tuesday, 25 January 2011, 10:05 GMT
Pushed to gerolde [1].

[1] http://projects.archlinux.org/aur.git/commit/?id=556de318aeeef6019bb7628389beee1358de93f8

Loading...