FS#15010 - [makepkg] rewriting groups in sub packages fails

Attached to Project: Pacman
Opened by Pierre Schmitz (Pierre) - Monday, 08 June 2009, 21:34 GMT
Last edited by Allan McRae (Allan) - Monday, 15 June 2009, 01:39 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Dan McGee (toofishes)
Allan McRae (Allan)
Architecture All
Severity Critical
Priority Normal
Reported Version git
Due in Version 3.3.0
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

I am using th latest makepkg version from git. I would like to define some groups globally but exclude certain sub packages from those. (e.g. because they are just libs) I use a PKGBUILD similar to the following:

pkgname=(pkg1 pkg2)
pkgver=1
pkgrel=1
groups=(a b)
arch=(any)

build() {
echo built
}

package_pkg1() {
groups=()
}

package_pkg2() {
echo ok
}

I would assume that pkg1 will have no groups while pkg2 inherits the global definition and would be member of group a and b. But pkg2 will only be member of group a.
This task depends upon

Closed by  Allan McRae (Allan)
Monday, 15 June 2009, 01:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  in git
Comment by Allan McRae (Allan) - Tuesday, 09 June 2009, 03:26 GMT
  • Field changed: Due in Version (Undecided → 3.3.0)
  • Field changed: Severity (Medium → Critical)
It is even worse than that... The backup/restore of variables is not capturing the whole array, just the first element. So dependencies can get screwed over too.

e.g.
pkgname=(pkg1 pkg2)
pkgver=1
pkgrel=1
depends=(gcc gtk2)
arch=(any)

build() {
echo built
}

package_pkg1() {
depends=(abs gcc gtk2)
}

package_pkg2() {
echo ok
}


pkg2's deps end up being "gcc gcc gtk2" (abs from pkg1 gets replaced with gcc from global depends).

Definite 3.3 blocker!
Comment by Allan McRae (Allan) - Tuesday, 09 June 2009, 04:15 GMT
Fixed by substituting some bash magic for different magic... I don't quite understand this but it works!
   0001-makepkg-fix-variable-bac... (1.2 KiB)
Comment by Allan McRae (Allan) - Monday, 15 June 2009, 01:38 GMT
Git commit: http://projects.archlinux.org/?p=pacman.git;a=commit;h=ef500b44

Loading...