Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#14868 - [ratpoison] fails to build

Attached to Project: Arch Linux
Opened by Sven Richter (sveri) - Friday, 29 May 2009, 07:04 GMT
Last edited by Ionut Biru (wonder) - Saturday, 07 November 2009, 18:01 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Aaron Griffin (phrakture)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Everytime i try to build ratpoison i get the following error:

history.c:78: error: static declaration of ‘getline’ follows non-static declaration
/usr/include/stdio.h:651: note: previous declaration of ‘getline’ was here
make[2]: *** [history.o] Error 1
make[2]: Leaving directory `/home/sveri/abs/ratpoison/src/ratpoison-1.4.4/src'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/sveri/abs/ratpoison/src/ratpoison-1.4.4/src'
make: *** [all-recursive] Error 1
==> ERROR: Build Failed.
Aborting...


It doesnt matter if i try it by hand or the git version in aur.


This task depends upon

Closed by  Ionut Biru (wonder)
Saturday, 07 November 2009, 18:01 GMT
Reason for closing:  Works for me
Comment by Thomas Dziedzic (tomd123) - Friday, 29 May 2009, 21:44 GMT
include a "#define HAVE_GETLINE" at the top of your history.c or in the ratpoison config file don't have the exact location at hand though.
Comment by Thomas Dziedzic (tomd123) - Saturday, 30 May 2009, 01:24 GMT
Ok, I had time to look over the code and the "proper" place to put it would be if you had a config.h file, if you don't put it in ratpoison.h
But really it doesn't affect anything, just as long as you put it before the line in history.c where it checks if HAVE_GETLINE
Comment by Thomas Dziedzic (tomd123) - Saturday, 30 May 2009, 01:24 GMT
is defined XD

sorry hit enter too early
Comment by Sven Richter (sveri) - Saturday, 30 May 2009, 11:59 GMT
Yea, thanks for looking.
But the problem is, if i try to build the package with a package build
it always recreates the config.h. So inserting the macro there doesnt
help. Its only applicable if i compile and install by hand.

And besides that, the problem must be somewhere else, i think
in the generation of the config.h.

I already found comparable bug with the same problem and it
did not get solved. At least not really, a workaround like the
above one is a little bit dirty.
Comment by Thomas Dziedzic (tomd123) - Saturday, 30 May 2009, 16:12 GMT
Oh, now I understand.. well you could just put the line right before it checks if the macro is defined in history.c for now and just build the package if you need it now.
I agree that this needs a better solution though.
Comment by Henning Garus (garns) - Sunday, 07 June 2009, 15:55 GMT
The check for getline is missing in configure.in. I have reported this upstream: http://lists.gnu.org/archive/html/ratpoison-devel/2009-06/msg00001.html

To get it to build you can add this patch and run autoreconf.
   RPconfigure.patch (0.5 KiB)
Comment by Henning Garus (garns) - Monday, 13 July 2009, 08:41 GMT
Fixed in git.
Comment by Laszlo Papp (djszapi) - Saturday, 03 October 2009, 22:01 GMT
I can build it from abs now without any problem, but 1.4.3 exists in the abs.

Loading...