FS#14716 - dcron hardcodes vi usage

Attached to Project: Arch Linux
Opened by Hussam Al-Tayeb (hussam) - Thursday, 14 May 2009, 07:54 GMT
Last edited by Tobias Powalowski (tpowa) - Friday, 15 May 2009, 07:23 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

dcron hardcodes vi usage. it won't recognize vim. Please either find a way to get it to use vim as well or make vi a dependency.
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Friday, 15 May 2009, 07:23 GMT
Reason for closing:  Fixed
Comment by Jan de Groot (JGC) - Thursday, 14 May 2009, 12:09 GMT
if ((ptr = getenv("VISUAL")) == NULL || strlen(ptr) > 256)
ptr = PATH_VI;

The default editor is set by the environment variable "VISUAL". I think it would be good to patch a fallback to the much more common variable "EDITOR", as that's what is used by vipw, vigr, cvs, svn and many others.

Edit:
This is even documented behaviour:
crontab will use /usr/bin/vi or
the editor specified by your VISUAL environment variable to edit the
crontab.

Loading...