FS#13791 - rc.sysinit doesn't check if root fs was remounted as rw correctly

Attached to Project: Arch Linux
Opened by Cedric Staub (csstaub) - Friday, 13 March 2009, 22:03 GMT
Last edited by Thomas Bächler (brain0) - Sunday, 31 May 2009, 14:29 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: In some cases, the filesystem might fail
to remount as read/write even after it mounted as read-only.
This can happen with for example JFS, as it refuses to
mount as read/write after an unclean reboot/unmount if
you don't call fsck on it first. What will happen is that
the command "/bin/mount -o remount,rw /" in rc.sysinit
will fail, but the system will (try) to continue with the
booting process anyway. This is suboptimal.

Additional info:
* Last checked with initscripts-2009.03

Steps to reproduce:
1. Force an unclean reboot on a system with a JFS root-partition
2. Watch your system fail to boot back up again
This task depends upon

Closed by  Thomas Bächler (brain0)
Sunday, 31 May 2009, 14:29 GMT
Reason for closing:  Not a bug
Comment by Aaron Griffin (phrakture) - Tuesday, 17 March 2009, 22:51 GMT
So, what steps should be taken if this DOES fail?
Comment by Thomas Bächler (brain0) - Tuesday, 17 March 2009, 23:13 GMT
From where I stand, fsck should be performed on each boot before remounting rw, UNLESS you explicitly disabled the fsck in fstab (0 in the "pass" column). If you did so, it is your fault.

I have to repeat Aaron's question, what should we do if remounting rw fails? Should we fsck ... wait, we did that directly before the remount! Should we stop booting?
Comment by Cedric Staub (csstaub) - Wednesday, 18 March 2009, 09:00 GMT
I think it would be best to run sulogin, to give the user a chance to fix the problem.
Comment by Thomas Bächler (brain0) - Sunday, 31 May 2009, 10:40 GMT
We already do that after fsck. It's quite weird that you would disable fsck in fstab on a filesystem that fails to remount-rw if you don't fsck.
Comment by Cedric Staub (csstaub) - Sunday, 31 May 2009, 11:58 GMT
You were right, I enabled it in the meantime.

Loading...