FS#13755 - xorg-xdm uses the depreceated xsm as default session management

Attached to Project: Arch Linux
Opened by Johannes Dewender (JonnyJD) - Wednesday, 11 March 2009, 18:49 GMT
Last edited by Eric Belanger (Snowman) - Tuesday, 28 April 2009, 20:27 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Eric Belanger (Snowman)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
/etc/X11/xdm/Xsession executes xsm when no .xession is found for the user.
The user is thrown right back to xdm, when xsm is not existent. This is logged in .xsession-errors.

This doesn't affect many archers, because most already have some .xsession file, but it is a great annoyance to users who install arch the first time and don't get xdm to work.
xsm is depreceated here, but it seems like it is still the standard session manager for xdm. So we should change this behavior with a patch.

My idea would be to use /etc/X11/xinit/xinitrc as a session script. I attach a patch for this solution.


Additional info:
* package version(s)
xorg-xdm 1.1.8-1
xorg-xsm (well, depreceated and not existent in arch anymore)
* config and/or log files etc.
/etc/X11/xdm/Xsession
~/.xsession (problem when not existent)


Steps to reproduce:
rename or remove ~/.xsession
login in xdm
   Xsession.patch (0.2 KiB)
This task depends upon

Closed by  Eric Belanger (Snowman)
Tuesday, 28 April 2009, 20:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in xorg-xdm-1.1.8-2
Comment by Johannes Dewender (JonnyJD) - Wednesday, 11 March 2009, 19:59 GMT
Well, if we use the /etc/X11/xinit/xinitrc anyways, we can use the ~/.xinitrc, too. On the other hand: ~/.Xressources is already inlcuded in the xinitrc normally, so we can skip that in Xsession.

Changed that in this patch and also inluded absolute filenames in the patch.

Maybe we should use something different then the xinit files (xorg-xinit would be needed for that) and include some default xsession. I have no clue why there isn't something like that already. A user should be able to start x in some default fashion when the .xsession is deleted or never existent.
   Xsession.patch (0.2 KiB)
Comment by Johannes Dewender (JonnyJD) - Wednesday, 11 March 2009, 21:34 GMT
Oh - my second patch is absolutely identical to the first one..
Well, here is the one I intended to send.
   Xsession.patch (0.5 KiB)
Comment by Johannes Dewender (JonnyJD) - Thursday, 12 March 2009, 03:47 GMT
Hm - okay. In order to get the profile read in we also need to make it a login shell. I think this is what is tried with the /bin/sh -ls -c ".xsession" also, but I don't think this is actually correct for the bourne shell. It works, because it is a symlink to bash.
Anyways, I added -l to my patch.
This is now how I use it on some system.
   Xsession.patch (0.5 KiB)
Comment by Eric Belanger (Snowman) - Sunday, 26 April 2009, 20:55 GMT
Jan: Do you want me to implement this while doing the license rebuild?
Comment by Jan de Groot (JGC) - Sunday, 26 April 2009, 21:17 GMT
Sure, go ahead.

Loading...